Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move inputs off heap with autofix: c services #41377

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Move inputs off heap with autofix: c services #41377

wants to merge 32 commits into from

Conversation

gdavison
Copy link
Contributor

Description

Allocates inputs on stack for those declared inline to the operation for c services.

@gdavison gdavison requested a review from a team as a code owner February 13, 2025 00:57
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/configservice Issues and PRs that pertain to the configservice service. service/codebuild Issues and PRs that pertain to the codebuild service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/codecommit Issues and PRs that pertain to the codecommit service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/cloudsearch Issues and PRs that pertain to the cloudsearch service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/cloud9 Issues and PRs that pertain to the cloud9 service. service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service. service/connect Issues and PRs that pertain to the connect service. service/comprehend Issues and PRs that pertain to the comprehend service. service/codestarnotifications Issues and PRs that pertain to the codestarnotifications service. service/codegurureviewer Issues and PRs that pertain to the codegurureviewer service. service/codestarconnections Issues and PRs that pertain to the codestarconnections service. service/codeartifact Issues and PRs that pertain to the codeartifact service. linter Pertains to changes to or issues with the various linters. generators Relates to code generators. service/ce Issues and PRs that pertain to the ce service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. service/cur Issues and PRs that pertain to the cur service. service/customerprofiles Issues and PRs that pertain to the customerprofiles service. service/controltower Issues and PRs that pertain to the controltower service. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. service/cleanrooms Issues and PRs that pertain to the cleanrooms service. labels Feb 13, 2025
@gdavison gdavison force-pushed the td-inputs-in-heap-c branch from e5780b2 to c1cf9c2 Compare February 14, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jar-b jar-b jar-b left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
generators Relates to code generators. linter Pertains to changes to or issues with the various linters. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/ce Issues and PRs that pertain to the ce service. service/chatbot Issues and PRs that pertain to the chatbot service. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. service/cleanrooms Issues and PRs that pertain to the cleanrooms service. service/cloud9 Issues and PRs that pertain to the cloud9 service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/cloudfrontkeyvaluestore Issues and PRs that pertain to the cloudfrontkeyvaluestore service. service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service. service/cloudsearch Issues and PRs that pertain to the cloudsearch service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/codeartifact Issues and PRs that pertain to the codeartifact service. service/codebuild Issues and PRs that pertain to the codebuild service. service/codecatalyst Issues and PRs that pertain to the codecatalyst service. service/codecommit Issues and PRs that pertain to the codecommit service. service/codegurureviewer Issues and PRs that pertain to the codegurureviewer service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/codestarconnections Issues and PRs that pertain to the codestarconnections service. service/codestarnotifications Issues and PRs that pertain to the codestarnotifications service. service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/comprehend Issues and PRs that pertain to the comprehend service. service/configservice Issues and PRs that pertain to the configservice service. service/connect Issues and PRs that pertain to the connect service. service/controltower Issues and PRs that pertain to the controltower service. service/costoptimizationhub Issues and PRs that pertain to the costoptimizationhub service. service/cur Issues and PRs that pertain to the cur service. service/customerprofiles Issues and PRs that pertain to the customerprofiles service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @jar-b