Tech debt: Use service package API client withExtraOptions mechanism

[ewbankkit]

Description

Use the service package API client withExtraOptions mechanism introduced in #41109 to specify extra Options. This allows all (except simpledb and meta) API client factory functions to be generated.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccAPIGatewayRestAPI_basic' PKG=apigateway
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/apigateway/... -v -count 1 -parallel 20  -run=TestAccAPIGatewayRestAPI_basic -timeout 360m -vet=off
2025/02/03 15:24:47 Initializing Terraform AWS Provider...
=== RUN   TestAccAPIGatewayRestAPI_basic
=== PAUSE TestAccAPIGatewayRestAPI_basic
=== CONT  TestAccAPIGatewayRestAPI_basic
--- PASS: TestAccAPIGatewayRestAPI_basic (15.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigateway	21.486s

% make testacc TESTARGS='-run=TestAccSiteVPNGateway_' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccSiteVPNGateway_ -timeout 360m -vet=off
2025/02/03 15:28:37 Initializing Terraform AWS Provider...
=== RUN   TestAccSiteVPNGateway_basic
=== PAUSE TestAccSiteVPNGateway_basic
=== RUN   TestAccSiteVPNGateway_withAvailabilityZoneSetToState
=== PAUSE TestAccSiteVPNGateway_withAvailabilityZoneSetToState
=== RUN   TestAccSiteVPNGateway_amazonSideASN
=== PAUSE TestAccSiteVPNGateway_amazonSideASN
=== RUN   TestAccSiteVPNGateway_disappears
=== PAUSE TestAccSiteVPNGateway_disappears
=== RUN   TestAccSiteVPNGateway_reattach
=== PAUSE TestAccSiteVPNGateway_reattach
=== RUN   TestAccSiteVPNGateway_tags
=== PAUSE TestAccSiteVPNGateway_tags
=== CONT  TestAccSiteVPNGateway_basic
=== CONT  TestAccSiteVPNGateway_disappears
=== CONT  TestAccSiteVPNGateway_amazonSideASN
=== CONT  TestAccSiteVPNGateway_withAvailabilityZoneSetToState
=== CONT  TestAccSiteVPNGateway_tags
=== CONT  TestAccSiteVPNGateway_reattach
--- PASS: TestAccSiteVPNGateway_amazonSideASN (107.58s)
--- PASS: TestAccSiteVPNGateway_withAvailabilityZoneSetToState (107.63s)
--- PASS: TestAccSiteVPNGateway_disappears (116.31s)
--- PASS: TestAccSiteVPNGateway_tags (147.34s)
--- PASS: TestAccSiteVPNGateway_basic (196.87s)
--- PASS: TestAccSiteVPNGateway_reattach (246.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	252.631s

% make testacc TESTARGS='-run=TestAccRoute53RecoveryReadinessResourceSet_basic' PKG=route53recoveryreadiness        
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/route53recoveryreadiness/... -v -count 1 -parallel 20  -run=TestAccRoute53RecoveryReadinessResourceSet_basic -timeout 360m -vet=off
2025/02/03 15:35:01 Initializing Terraform AWS Provider...
=== RUN   TestAccRoute53RecoveryReadinessResourceSet_basic
=== PAUSE TestAccRoute53RecoveryReadinessResourceSet_basic
=== RUN   TestAccRoute53RecoveryReadinessResourceSet_basicDNSTargetResource
=== PAUSE TestAccRoute53RecoveryReadinessResourceSet_basicDNSTargetResource
=== CONT  TestAccRoute53RecoveryReadinessResourceSet_basic
=== CONT  TestAccRoute53RecoveryReadinessResourceSet_basicDNSTargetResource
--- PASS: TestAccRoute53RecoveryReadinessResourceSet_basic (15.38s)
--- PASS: TestAccRoute53RecoveryReadinessResourceSet_basicDNSTargetResource (15.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53recoveryreadiness	21.197s

% make testacc TESTARGS='-run=TestAccDynamoDBTable_basic' PKG=dynamodb
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/dynamodb/... -v -count 1 -parallel 20  -run=TestAccDynamoDBTable_basic -timeout 360m -vet=off
2025/02/03 15:37:53 Initializing Terraform AWS Provider...
=== RUN   TestAccDynamoDBTable_basic
=== PAUSE TestAccDynamoDBTable_basic
=== CONT  TestAccDynamoDBTable_basic
--- PASS: TestAccDynamoDBTable_basic (22.87s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	28.423s

% make testacc TESTARGS='-run=TestAccS3Bucket_Basic_basic' PKG=s3     
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/s3/... -v -count 1 -parallel 20  -run=TestAccS3Bucket_Basic_basic -timeout 360m -vet=off
2025/02/03 15:50:00 Initializing Terraform AWS Provider...
=== RUN   TestAccS3Bucket_Basic_basic
=== PAUSE TestAccS3Bucket_Basic_basic
=== CONT  TestAccS3Bucket_Basic_basic
--- PASS: TestAccS3Bucket_Basic_basic (18.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	24.736s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM

Can we update this section of the contributor guide to replace the custom NewClient implementation with a withExtraOptions example?

https://hashicorp.github.io/terraform-provider-aws/add-a-new-service/#customizing-a-new-service-client

[ewbankkit]

@jar-b Contributors Guide updated.

[jar-b]

LGTM 🚀

[github-actions]

This functionality has been released in v5.86.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!