Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Add missing Target Key #41209

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

djsd123
Copy link
Contributor

@djsd123 djsd123 commented Feb 3, 2025

Description

Add missing target key Functions to relevant validate function

See docs

Relations

Closes #41208

References

Output from Acceptance Testing

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/fis/... -v -count 1 -parallel 20 -run='TestAccFISExperimentTemplate_basic'  -timeout 360m -vet=off
2025/02/03 18:04:40 Initializing Terraform AWS Provider...
=== RUN   TestAccFISExperimentTemplate_basic
=== PAUSE TestAccFISExperimentTemplate_basic
=== CONT  TestAccFISExperimentTemplate_basic
--- PASS: TestAccFISExperimentTemplate_basic (23.80s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fis        26.916s
% make testacc TESTS=TestAccXXX PKG=ec2

...

Add missing target key `Functions` to relevant validate function

See [docs](https://docs.aws.amazon.com/fis/latest/userguide/use-lambda-actions.html)
@djsd123 djsd123 requested a review from a team as a code owner February 3, 2025 18:16
Copy link

github-actions bot commented Feb 3, 2025

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/fis Issues and PRs that pertain to the fis service. needs-triage Waiting for first response or review from a maintainer. labels Feb 3, 2025
@djsd123 djsd123 marked this pull request as draft February 3, 2025 18:43
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/fis Issues and PRs that pertain to the fis service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: FIS Action Lambda Function Target
2 participants