Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow name, name_prefix_and path update for aws_iam_server_certificate #41186

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Feb 1, 2025

Description

This PR is to allow updating the name, name_prefix, and path arguments of the aws_iam_server_certificate resource without force creating a new one.

Note that there is still one limitation, where you cannot update the resource with both name and name_prefix set to null to change to a fully-generated name. Since both of these arguments are optional + computed, the plan will simply detect no changes.

As well, there is an account-level quota limit on 20 IAM server certificates. You'll either have to request for a quota increase (which I did, to 40) or set -parallel to a smaller number than 20.

Relations

Closes #37479

References

Referred to UpdateServerCertificate for specs and wordings.

Output from Acceptance Testing

$ make testacc TESTS=TestAccIAMServerCertificate_      PKG=iam
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMServerCertificate_'  -timeout 360m -vet=off
2025/02/01 16:12:25 Initializing Terraform AWS Provider...
=== RUN   TestAccIAMServerCertificate_tags
=== PAUSE TestAccIAMServerCertificate_tags
=== RUN   TestAccIAMServerCertificate_tags_null
=== PAUSE TestAccIAMServerCertificate_tags_null
=== RUN   TestAccIAMServerCertificate_tags_EmptyMap
=== PAUSE TestAccIAMServerCertificate_tags_EmptyMap
=== RUN   TestAccIAMServerCertificate_tags_AddOnUpdate
=== PAUSE TestAccIAMServerCertificate_tags_AddOnUpdate
=== RUN   TestAccIAMServerCertificate_tags_EmptyTag_OnCreate
=== PAUSE TestAccIAMServerCertificate_tags_EmptyTag_OnCreate
=== RUN   TestAccIAMServerCertificate_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccIAMServerCertificate_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccIAMServerCertificate_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccIAMServerCertificate_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccIAMServerCertificate_tags_DefaultTags_providerOnly
=== PAUSE TestAccIAMServerCertificate_tags_DefaultTags_providerOnly
=== RUN   TestAccIAMServerCertificate_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccIAMServerCertificate_tags_DefaultTags_nonOverlapping
=== RUN   TestAccIAMServerCertificate_tags_DefaultTags_overlapping
=== PAUSE TestAccIAMServerCertificate_tags_DefaultTags_overlapping
=== RUN   TestAccIAMServerCertificate_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccIAMServerCertificate_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccIAMServerCertificate_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccIAMServerCertificate_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccIAMServerCertificate_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccIAMServerCertificate_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccIAMServerCertificate_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccIAMServerCertificate_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccIAMServerCertificate_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccIAMServerCertificate_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccIAMServerCertificate_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccIAMServerCertificate_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccIAMServerCertificate_tags_ComputedTag_OnCreate
=== PAUSE TestAccIAMServerCertificate_tags_ComputedTag_OnCreate
=== RUN   TestAccIAMServerCertificate_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccIAMServerCertificate_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccIAMServerCertificate_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccIAMServerCertificate_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccIAMServerCertificate_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccIAMServerCertificate_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccIAMServerCertificate_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccIAMServerCertificate_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccIAMServerCertificate_basic
=== PAUSE TestAccIAMServerCertificate_basic
=== RUN   TestAccIAMServerCertificate_nameGenerated
=== PAUSE TestAccIAMServerCertificate_nameGenerated
=== RUN   TestAccIAMServerCertificate_namePrefix
=== PAUSE TestAccIAMServerCertificate_namePrefix
=== RUN   TestAccIAMServerCertificate_disappears
=== PAUSE TestAccIAMServerCertificate_disappears
=== RUN   TestAccIAMServerCertificate_file
=== PAUSE TestAccIAMServerCertificate_file
=== RUN   TestAccIAMServerCertificate_path
=== PAUSE TestAccIAMServerCertificate_path
=== CONT  TestAccIAMServerCertificate_tags
=== CONT  TestAccIAMServerCertificate_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccIAMServerCertificate_path
=== CONT  TestAccIAMServerCertificate_file
=== CONT  TestAccIAMServerCertificate_disappears
=== CONT  TestAccIAMServerCertificate_namePrefix
=== CONT  TestAccIAMServerCertificate_nameGenerated
=== CONT  TestAccIAMServerCertificate_basic
=== CONT  TestAccIAMServerCertificate_tags_IgnoreTags_Overlap_ResourceTag
=== CONT  TestAccIAMServerCertificate_tags_IgnoreTags_Overlap_DefaultTag
=== CONT  TestAccIAMServerCertificate_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccIAMServerCertificate_tags_ComputedTag_OnUpdate_Add
=== CONT  TestAccIAMServerCertificate_tags_ComputedTag_OnCreate
=== CONT  TestAccIAMServerCertificate_tags_DefaultTags_providerOnly
=== CONT  TestAccIAMServerCertificate_tags_DefaultTags_emptyProviderOnlyTag
=== CONT  TestAccIAMServerCertificate_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccIAMServerCertificate_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccIAMServerCertificate_tags_DefaultTags_updateToResourceOnly
=== CONT  TestAccIAMServerCertificate_tags_EmptyTag_OnCreate
=== CONT  TestAccIAMServerCertificate_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccIAMServerCertificate_nameGenerated (40.32s)
=== CONT  TestAccIAMServerCertificate_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccIAMServerCertificate_disappears (41.27s)
=== CONT  TestAccIAMServerCertificate_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_emptyProviderOnlyTag (54.93s)
=== CONT  TestAccIAMServerCertificate_tags_DefaultTags_overlapping
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_nullNonOverlappingResourceTag (57.39s)
=== CONT  TestAccIAMServerCertificate_tags_EmptyMap
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_nullOverlappingResourceTag (58.36s)
=== CONT  TestAccIAMServerCertificate_tags_AddOnUpdate
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_emptyResourceTag (59.37s)
=== CONT  TestAccIAMServerCertificate_tags_DefaultTags_nonOverlapping
--- PASS: TestAccIAMServerCertificate_tags_ComputedTag_OnCreate (63.38s)
=== CONT  TestAccIAMServerCertificate_tags_null
--- PASS: TestAccIAMServerCertificate_file (75.16s)
--- PASS: TestAccIAMServerCertificate_basic (83.18s)
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_updateToResourceOnly (86.24s)
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_updateToProviderOnly (93.21s)
--- PASS: TestAccIAMServerCertificate_tags_ComputedTag_OnUpdate_Add (98.26s)
--- PASS: TestAccIAMServerCertificate_tags_ComputedTag_OnUpdate_Replace (98.97s)
--- PASS: TestAccIAMServerCertificate_tags_EmptyTag_OnCreate (100.51s)
--- PASS: TestAccIAMServerCertificate_path (105.76s)
--- PASS: TestAccIAMServerCertificate_tags_IgnoreTags_Overlap_DefaultTag (109.71s)
--- PASS: TestAccIAMServerCertificate_namePrefix (115.21s)
--- PASS: TestAccIAMServerCertificate_tags_EmptyMap (58.04s)
--- PASS: TestAccIAMServerCertificate_tags_EmptyTag_OnUpdate_Replace (76.03s)
--- PASS: TestAccIAMServerCertificate_tags_null (55.89s)
--- PASS: TestAccIAMServerCertificate_tags_AddOnUpdate (66.99s)
--- PASS: TestAccIAMServerCertificate_tags_IgnoreTags_Overlap_ResourceTag (128.95s)
--- PASS: TestAccIAMServerCertificate_tags_EmptyTag_OnUpdate_Add (94.52s)
--- PASS: TestAccIAMServerCertificate_tags (140.48s)
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_providerOnly (142.77s)
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_overlapping (90.18s)
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_nonOverlapping (86.39s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iam        148.480s

$

@acwwat acwwat requested a review from a team as a code owner February 1, 2025 21:23
Copy link

github-actions bot commented Feb 1, 2025

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/iam Issues and PRs that pertain to the iam service. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Feb 1, 2025
@acwwat acwwat force-pushed the b-aws_iam_server_certificate-allow_arg_updates branch from 794eacb to 8f1c7df Compare February 1, 2025 21:25
@acwwat acwwat force-pushed the b-aws_iam_server_certificate-allow_arg_updates branch from 8f1c7df to e8df824 Compare February 1, 2025 21:50
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 3, 2025
@ewbankkit ewbankkit self-assigned this Feb 3, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 3, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIAMServerCertificate_' PKG=iam ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/iam/... -v -count 1 -parallel 3  -run=TestAccIAMServerCertificate_ -timeout 360m -vet=off
2025/02/03 08:44:10 Initializing Terraform AWS Provider...
=== RUN   TestAccIAMServerCertificate_tags
=== PAUSE TestAccIAMServerCertificate_tags
=== RUN   TestAccIAMServerCertificate_tags_null
=== PAUSE TestAccIAMServerCertificate_tags_null
=== RUN   TestAccIAMServerCertificate_tags_EmptyMap
=== PAUSE TestAccIAMServerCertificate_tags_EmptyMap
=== RUN   TestAccIAMServerCertificate_tags_AddOnUpdate
=== PAUSE TestAccIAMServerCertificate_tags_AddOnUpdate
=== RUN   TestAccIAMServerCertificate_tags_EmptyTag_OnCreate
=== PAUSE TestAccIAMServerCertificate_tags_EmptyTag_OnCreate
=== RUN   TestAccIAMServerCertificate_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccIAMServerCertificate_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccIAMServerCertificate_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccIAMServerCertificate_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccIAMServerCertificate_tags_DefaultTags_providerOnly
=== PAUSE TestAccIAMServerCertificate_tags_DefaultTags_providerOnly
=== RUN   TestAccIAMServerCertificate_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccIAMServerCertificate_tags_DefaultTags_nonOverlapping
=== RUN   TestAccIAMServerCertificate_tags_DefaultTags_overlapping
=== PAUSE TestAccIAMServerCertificate_tags_DefaultTags_overlapping
=== RUN   TestAccIAMServerCertificate_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccIAMServerCertificate_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccIAMServerCertificate_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccIAMServerCertificate_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccIAMServerCertificate_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccIAMServerCertificate_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccIAMServerCertificate_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccIAMServerCertificate_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccIAMServerCertificate_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccIAMServerCertificate_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccIAMServerCertificate_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccIAMServerCertificate_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccIAMServerCertificate_tags_ComputedTag_OnCreate
=== PAUSE TestAccIAMServerCertificate_tags_ComputedTag_OnCreate
=== RUN   TestAccIAMServerCertificate_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccIAMServerCertificate_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccIAMServerCertificate_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccIAMServerCertificate_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccIAMServerCertificate_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccIAMServerCertificate_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccIAMServerCertificate_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccIAMServerCertificate_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccIAMServerCertificate_basic
=== PAUSE TestAccIAMServerCertificate_basic
=== RUN   TestAccIAMServerCertificate_nameGenerated
=== PAUSE TestAccIAMServerCertificate_nameGenerated
=== RUN   TestAccIAMServerCertificate_namePrefix
=== PAUSE TestAccIAMServerCertificate_namePrefix
=== RUN   TestAccIAMServerCertificate_disappears
=== PAUSE TestAccIAMServerCertificate_disappears
=== RUN   TestAccIAMServerCertificate_file
=== PAUSE TestAccIAMServerCertificate_file
=== RUN   TestAccIAMServerCertificate_path
=== PAUSE TestAccIAMServerCertificate_path
=== CONT  TestAccIAMServerCertificate_tags
=== CONT  TestAccIAMServerCertificate_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccIAMServerCertificate_basic
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_nullOverlappingResourceTag (12.90s)
=== CONT  TestAccIAMServerCertificate_path
--- PASS: TestAccIAMServerCertificate_basic (18.04s)
=== CONT  TestAccIAMServerCertificate_file
--- PASS: TestAccIAMServerCertificate_file (16.94s)
=== CONT  TestAccIAMServerCertificate_disappears
=== CONT  TestAccIAMServerCertificate_namePrefix
--- PASS: TestAccIAMServerCertificate_path (24.64s)
--- PASS: TestAccIAMServerCertificate_tags (43.15s)
=== CONT  TestAccIAMServerCertificate_nameGenerated
--- PASS: TestAccIAMServerCertificate_disappears (9.46s)
=== CONT  TestAccIAMServerCertificate_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccIAMServerCertificate_nameGenerated (8.87s)
=== CONT  TestAccIAMServerCertificate_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_updateToResourceOnly (19.58s)
=== CONT  TestAccIAMServerCertificate_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_emptyProviderOnlyTag (12.74s)
=== CONT  TestAccIAMServerCertificate_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccIAMServerCertificate_namePrefix (28.64s)
=== CONT  TestAccIAMServerCertificate_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_emptyResourceTag (12.54s)
=== CONT  TestAccIAMServerCertificate_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccIAMServerCertificate_tags_ComputedTag_OnUpdate_Replace (22.91s)
=== CONT  TestAccIAMServerCertificate_tags_ComputedTag_OnCreate
--- PASS: TestAccIAMServerCertificate_tags_IgnoreTags_Overlap_ResourceTag (29.52s)
=== CONT  TestAccIAMServerCertificate_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccIAMServerCertificate_tags_IgnoreTags_Overlap_DefaultTag (25.44s)
=== CONT  TestAccIAMServerCertificate_tags_EmptyTag_OnCreate
--- PASS: TestAccIAMServerCertificate_tags_ComputedTag_OnCreate (15.16s)
=== CONT  TestAccIAMServerCertificate_tags_DefaultTags_providerOnly
--- PASS: TestAccIAMServerCertificate_tags_ComputedTag_OnUpdate_Add (23.02s)
=== CONT  TestAccIAMServerCertificate_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccIAMServerCertificate_tags_EmptyTag_OnCreate (22.12s)
=== CONT  TestAccIAMServerCertificate_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccIAMServerCertificate_tags_EmptyTag_OnUpdate_Replace (19.79s)
=== CONT  TestAccIAMServerCertificate_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_updateToProviderOnly (20.28s)
=== CONT  TestAccIAMServerCertificate_tags_DefaultTags_overlapping
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_providerOnly (42.56s)
=== CONT  TestAccIAMServerCertificate_tags_EmptyMap
--- PASS: TestAccIAMServerCertificate_tags_EmptyMap (15.28s)
=== CONT  TestAccIAMServerCertificate_tags_DefaultTags_nonOverlapping
--- PASS: TestAccIAMServerCertificate_tags_EmptyTag_OnUpdate_Add (30.17s)
=== CONT  TestAccIAMServerCertificate_tags_AddOnUpdate
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_overlapping (32.73s)
=== CONT  TestAccIAMServerCertificate_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccIAMServerCertificate_tags_AddOnUpdate (20.15s)
=== CONT  TestAccIAMServerCertificate_tags_null
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_nullNonOverlappingResourceTag (12.60s)
--- PASS: TestAccIAMServerCertificate_tags_DefaultTags_nonOverlapping (32.69s)
--- PASS: TestAccIAMServerCertificate_tags_null (17.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	213.496s

@ewbankkit
Copy link
Contributor

@acwwat Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 0bb20e1 into hashicorp:main Feb 3, 2025
56 checks passed
@github-actions github-actions bot added this to the v5.85.0 milestone Feb 3, 2025
@acwwat acwwat deleted the b-aws_iam_server_certificate-allow_arg_updates branch February 3, 2025 19:08
Copy link

github-actions bot commented Feb 3, 2025

This functionality has been released in v5.85.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource/aws_iam_server_certificate: Changing name or path does not need to recreate resource
2 participants