Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typo): fixes typo in "awiting for Lambda Function" message #40862

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nicolaschambrier
Copy link

Description

This fixes a small typo in error messages:

╷
│ Error: awiting for Lambda Function (******) create: unexpected state 'Failed', wanted target 'Active'. last error: InternalError: Error while creating lambda: 
│ 
│   with module.******.aws_lambda_function.this,
│   on main.tf line 66, in resource "aws_lambda_function" "this":
│   66: resource "aws_lambda_function" "this" {
│ 
╵

@nicolaschambrier nicolaschambrier requested a review from a team as a code owner January 10, 2025 09:59
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/lambda Issues and PRs that pertain to the lambda service. needs-triage Waiting for first response or review from a maintainer. labels Jan 10, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @nicolaschambrier 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 10, 2025
@@ -597,11 +597,11 @@ func resourceFunctionCreate(ctx context.Context, d *schema.ResourceData, meta in
})

if err != nil {
return sdkdiag.AppendErrorf(diags, "awiting for Lambda Function (%s) create: %s", d.Id(), err)
return sdkdiag.AppendErrorf(diags, "awaiting for Lambda Function (%s) create: %s", d.Id(), err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return sdkdiag.AppendErrorf(diags, "awaiting for Lambda Function (%s) create: %s", d.Id(), err)
return sdkdiag.AppendErrorf(diags, "waiting for Lambda Function (%s) create: %s", d.Id(), err)

We usually use waiting for ... in such error messages.

}

if _, err := waitFunctionCreated(ctx, conn, d.Id(), d.Timeout(schema.TimeoutCreate)); err != nil {
return sdkdiag.AppendErrorf(diags, "awiting for Lambda Function (%s) create: %s", d.Id(), err)
return sdkdiag.AppendErrorf(diags, "awaiting for Lambda Function (%s) create: %s", d.Id(), err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return sdkdiag.AppendErrorf(diags, "awaiting for Lambda Function (%s) create: %s", d.Id(), err)
return sdkdiag.AppendErrorf(diags, "waiting for Lambda Function (%s) create: %s", d.Id(), err)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/lambda Issues and PRs that pertain to the lambda service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants