Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new AWS Asia Pacific (Thailand) Region ap-southeast-7 in data sources #40850

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Support new AWS Asia Pacific (Thailand) Region ap-southeast-7 in data sources #40850

merged 4 commits into from
Jan 9, 2025
+15 −0

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jan 9, 2025 •
edited
Loading

Description

Adds data source support for the new AWS Region ap-southeast-7.

Relations

Closes #40832.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccS3BucketDataSource_basic' PKG=s3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/s3/... -v -count 1 -parallel 20  -run=TestAccS3BucketDataSource_basic -timeout 360m
2025/01/09 09:46:27 Initializing Terraform AWS Provider...
=== RUN   TestAccS3BucketDataSource_basic
=== PAUSE TestAccS3BucketDataSource_basic
=== CONT  TestAccS3BucketDataSource_basic
--- PASS: TestAccS3BucketDataSource_basic (14.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	20.380s
% make testacc TESTARGS='-run=TestAccELBHostedZoneIDDataSource_' PKG=elb
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/elb/... -v -count 1 -parallel 20  -run=TestAccELBHostedZoneIDDataSource_ -timeout 360m
2025/01/09 09:52:50 Initializing Terraform AWS Provider...
=== RUN   TestAccELBHostedZoneIDDataSource_basic
=== PAUSE TestAccELBHostedZoneIDDataSource_basic
=== CONT  TestAccELBHostedZoneIDDataSource_basic
--- PASS: TestAccELBHostedZoneIDDataSource_basic (13.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elb	18.615s
% make testacc TESTARGS='-run=TestAccELBV2HostedZoneIDDataSource_' PKG=elbv2 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/elbv2/... -v -count 1 -parallel 20  -run=TestAccELBV2HostedZoneIDDataSource_ -timeout 360m
2025/01/09 09:54:31 Initializing Terraform AWS Provider...
=== RUN   TestAccELBV2HostedZoneIDDataSource_basic
=== PAUSE TestAccELBV2HostedZoneIDDataSource_basic
=== CONT  TestAccELBV2HostedZoneIDDataSource_basic
--- PASS: TestAccELBV2HostedZoneIDDataSource_basic (23.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	29.227s

@ewbankkit ewbankkit requested a review from a team as a code owner January 9, 2025 14:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/s3 Issues and PRs that pertain to the s3 service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/elb Issues and PRs that pertain to the elb service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Jan 9, 2025
jar-b
jar-b approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit merged commit cc6308d into main Jan 9, 2025
52 checks passed
@ewbankkit ewbankkit deleted the f-ap-southeast-7 branch January 9, 2025 15:26
@github-actions github-actions bot added this to the v5.83.0 milestone Jan 9, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Jan 9, 2025
Update CHANGELOG.md for #40850
0c015d0
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

This functionality has been released in v5.83.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/s3 Issues and PRs that pertain to the s3 service.
Projects
None yet
Milestone
v5.83.0
Development

Successfully merging this pull request may close these issues.

New AWS Region: ap-southeast-7
2 participants
@ewbankkit @jar-b