Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource: aws_vpclattice_resource_gateway #40821

Merged
merged 20 commits into from
Jan 9, 2025

Conversation

ddericco
Copy link
Contributor

@ddericco ddericco commented Jan 7, 2025

Description

Adds new resource aws_vpclattice_resource_gateway to enable access to VPC resources over Lattice or PrivateLink.

Relations

Relates #40384

References

Output from Acceptance Testing

$ make testacc TESTS='TestAccVPCLatticeResourceGateway' PKG=vpclattice
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/vpclattice/... -v -count 1 -parallel 20 -run='TestAccVPCLatticeResourceGateway'  -timeout 360m
2025/01/08 12:13:02 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCLatticeResourceGateway_basic
=== PAUSE TestAccVPCLatticeResourceGateway_basic
=== RUN   TestAccVPCLatticeResourceGateway_addressTypeDualstack
=== PAUSE TestAccVPCLatticeResourceGateway_addressTypeDualstack
=== RUN   TestAccVPCLatticeResourceGateway_addressTypeIPv6
=== PAUSE TestAccVPCLatticeResourceGateway_addressTypeIPv6
=== RUN   TestAccVPCLatticeResourceGateway_multipleSubnets
=== PAUSE TestAccVPCLatticeResourceGateway_multipleSubnets
=== RUN   TestAccVPCLatticeResourceGateway_tags
=== PAUSE TestAccVPCLatticeResourceGateway_tags
=== RUN   TestAccVPCLatticeResourceGateway_update
=== PAUSE TestAccVPCLatticeResourceGateway_update
=== RUN   TestAccVPCLatticeResourceGateway_disappears
=== PAUSE TestAccVPCLatticeResourceGateway_disappears
=== CONT  TestAccVPCLatticeResourceGateway_basic
=== CONT  TestAccVPCLatticeResourceGateway_tags
=== CONT  TestAccVPCLatticeResourceGateway_addressTypeIPv6
=== CONT  TestAccVPCLatticeResourceGateway_disappears
=== CONT  TestAccVPCLatticeResourceGateway_addressTypeDualstack
=== CONT  TestAccVPCLatticeResourceGateway_update
=== CONT  TestAccVPCLatticeResourceGateway_multipleSubnets
--- PASS: TestAccVPCLatticeResourceGateway_disappears (41.82s)
--- PASS: TestAccVPCLatticeResourceGateway_basic (45.14s)
--- PASS: TestAccVPCLatticeResourceGateway_multipleSubnets (64.53s)
--- PASS: TestAccVPCLatticeResourceGateway_addressTypeDualstack (64.84s)
--- PASS: TestAccVPCLatticeResourceGateway_tags (86.74s)
--- PASS: TestAccVPCLatticeResourceGateway_addressTypeIPv6 (93.66s)
--- PASS: TestAccVPCLatticeResourceGateway_update (123.60s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice 129.250s

Copy link

github-actions bot commented Jan 7, 2025

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/vpclattice Issues and PRs that pertain to the vpclattice service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Jan 7, 2025
@ddericco ddericco marked this pull request as ready for review January 8, 2025 17:22
@ddericco ddericco requested a review from a team as a code owner January 8, 2025 17:22
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jan 8, 2025
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 8, 2025
@ewbankkit ewbankkit self-assigned this Jan 8, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 8, 2025
ewbankkit
ewbankkit previously approved these changes Jan 8, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCLatticeResourceGateway_' PKG=vpclattice ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/vpclattice/... -v -count 1 -parallel 3  -run=TestAccVPCLatticeResourceGateway_ -timeout 360m
2025/01/08 16:43:41 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCLatticeResourceGateway_basic
=== PAUSE TestAccVPCLatticeResourceGateway_basic
=== RUN   TestAccVPCLatticeResourceGateway_addressTypeDualstack
=== PAUSE TestAccVPCLatticeResourceGateway_addressTypeDualstack
=== RUN   TestAccVPCLatticeResourceGateway_addressTypeIPv6
=== PAUSE TestAccVPCLatticeResourceGateway_addressTypeIPv6
=== RUN   TestAccVPCLatticeResourceGateway_multipleSubnets
=== PAUSE TestAccVPCLatticeResourceGateway_multipleSubnets
=== RUN   TestAccVPCLatticeResourceGateway_tags
=== PAUSE TestAccVPCLatticeResourceGateway_tags
=== RUN   TestAccVPCLatticeResourceGateway_update
=== PAUSE TestAccVPCLatticeResourceGateway_update
=== RUN   TestAccVPCLatticeResourceGateway_disappears
=== PAUSE TestAccVPCLatticeResourceGateway_disappears
=== CONT  TestAccVPCLatticeResourceGateway_basic
=== CONT  TestAccVPCLatticeResourceGateway_tags
=== CONT  TestAccVPCLatticeResourceGateway_disappears
--- PASS: TestAccVPCLatticeResourceGateway_disappears (30.64s)
=== CONT  TestAccVPCLatticeResourceGateway_update
--- PASS: TestAccVPCLatticeResourceGateway_basic (36.20s)
=== CONT  TestAccVPCLatticeResourceGateway_addressTypeIPv6
--- PASS: TestAccVPCLatticeResourceGateway_addressTypeIPv6 (33.73s)
=== CONT  TestAccVPCLatticeResourceGateway_multipleSubnets
--- PASS: TestAccVPCLatticeResourceGateway_tags (74.29s)
=== CONT  TestAccVPCLatticeResourceGateway_addressTypeDualstack
--- PASS: TestAccVPCLatticeResourceGateway_update (59.16s)
--- PASS: TestAccVPCLatticeResourceGateway_multipleSubnets (34.18s)
--- PASS: TestAccVPCLatticeResourceGateway_addressTypeDualstack (33.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice	113.393s

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit
Copy link
Contributor

@ddericco Thanks for the contribution 🎉 👏.

1 similar comment
@ewbankkit
Copy link
Contributor

@ddericco Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 4af7c2f into hashicorp:main Jan 9, 2025
44 checks passed
@github-actions github-actions bot added this to the v5.83.0 milestone Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

This functionality has been released in v5.83.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/vpclattice Issues and PRs that pertain to the vpclattice service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants