Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING] 💥 remove compute environments from job queue #40751

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[BREAKING] 💥 remove compute environments from job queue #40751

wants to merge 3 commits into from

Conversation

danquack
Copy link
Contributor

@danquack danquack commented Jan 2, 2025 •
edited
Loading

Description

  • Remove deprecated parameter compute_environments
  • Replace SDKMigration test with compute environments removal test
  • Change read function to use autoflex

Relations

Closes #39568
Closes #34794
Relates #34750

References

Output from Acceptance Testing

Note: ACCTEST_PARALLELISM is used in this test due to the creation of VPC limits.

% TF_ACC=1 make testacc TESTS=TestAccBatchJobQueue_ ACCTEST_PARALLELISM=2 PKG=batch                                                                                               
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/batch/... -v -count 1 -parallel 2 -run='TestAccBatchJobQueue_'  -timeout 360m
2025/01/02 14:17:22 Initializing Terraform AWS Provider...
=== RUN   TestAccBatchJobQueue_migrateFromComputeEnvironments
=== PAUSE TestAccBatchJobQueue_migrateFromComputeEnvironments
=== RUN   TestAccBatchJobQueue_tags
=== PAUSE TestAccBatchJobQueue_tags
=== RUN   TestAccBatchJobQueue_tags_null
=== PAUSE TestAccBatchJobQueue_tags_null
=== RUN   TestAccBatchJobQueue_tags_EmptyMap
=== PAUSE TestAccBatchJobQueue_tags_EmptyMap
=== RUN   TestAccBatchJobQueue_tags_AddOnUpdate
=== PAUSE TestAccBatchJobQueue_tags_AddOnUpdate
=== RUN   TestAccBatchJobQueue_tags_EmptyTag_OnCreate
=== PAUSE TestAccBatchJobQueue_tags_EmptyTag_OnCreate
=== RUN   TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_providerOnly
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_providerOnly
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_nonOverlapping
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_overlapping
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_overlapping
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccBatchJobQueue_tags_ComputedTag_OnCreate
=== PAUSE TestAccBatchJobQueue_tags_ComputedTag_OnCreate
=== RUN   TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccBatchJobQueue_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccBatchJobQueue_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccBatchJobQueue_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccBatchJobQueue_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccBatchJobQueue_basic
=== PAUSE TestAccBatchJobQueue_basic
=== RUN   TestAccBatchJobQueue_disappears
=== PAUSE TestAccBatchJobQueue_disappears
=== RUN   TestAccBatchJobQueue_ComputeEnvironments_multiple
=== PAUSE TestAccBatchJobQueue_ComputeEnvironments_multiple
=== RUN   TestAccBatchJobQueue_ComputeEnvironmentOrder_multiple
=== PAUSE TestAccBatchJobQueue_ComputeEnvironmentOrder_multiple
=== RUN   TestAccBatchJobQueue_ComputeEnvironments_externalOrderUpdate
=== PAUSE TestAccBatchJobQueue_ComputeEnvironments_externalOrderUpdate
=== RUN   TestAccBatchJobQueue_priority
=== PAUSE TestAccBatchJobQueue_priority
=== RUN   TestAccBatchJobQueue_schedulingPolicy
=== PAUSE TestAccBatchJobQueue_schedulingPolicy
=== RUN   TestAccBatchJobQueue_state
=== PAUSE TestAccBatchJobQueue_state
=== RUN   TestAccBatchJobQueue_jobStateTimeLimitActionsMultiple
=== PAUSE TestAccBatchJobQueue_jobStateTimeLimitActionsMultiple
=== CONT  TestAccBatchJobQueue_migrateFromComputeEnvironments
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_nullNonOverlappingResourceTag (134.69s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_providerOnly
--- PASS: TestAccBatchJobQueue_migrateFromComputeEnvironments (162.15s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_providerOnly (186.92s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_nullOverlappingResourceTag (164.53s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_emptyProviderOnlyTag (132.85s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_emptyResourceTag (131.89s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_updateToResourceOnly (146.94s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_overlapping
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_updateToProviderOnly (146.96s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_nonOverlapping
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_overlapping (166.82s)
=== CONT  TestAccBatchJobQueue_tags_AddOnUpdate
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_nonOverlapping (167.05s)
=== CONT  TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Replace (134.74s)
=== CONT  TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccBatchJobQueue_tags_AddOnUpdate (140.82s)
=== CONT  TestAccBatchJobQueue_tags_EmptyTag_OnCreate
--- PASS: TestAccBatchJobQueue_tags_EmptyTag_OnCreate (142.85s)
=== CONT  TestAccBatchJobQueue_ComputeEnvironments_multiple
--- PASS: TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Add (145.84s)
=== CONT  TestAccBatchJobQueue_jobStateTimeLimitActionsMultiple
--- PASS: TestAccBatchJobQueue_jobStateTimeLimitActionsMultiple (167.44s)
=== CONT  TestAccBatchJobQueue_state
--- PASS: TestAccBatchJobQueue_ComputeEnvironments_multiple (170.09s)
=== CONT  TestAccBatchJobQueue_schedulingPolicy
--- PASS: TestAccBatchJobQueue_state (168.71s)
=== CONT  TestAccBatchJobQueue_priority
--- PASS: TestAccBatchJobQueue_schedulingPolicy (175.17s)
=== CONT  TestAccBatchJobQueue_ComputeEnvironments_externalOrderUpdate
--- PASS: TestAccBatchJobQueue_ComputeEnvironments_externalOrderUpdate (127.99s)
=== CONT  TestAccBatchJobQueue_ComputeEnvironmentOrder_multiple
--- PASS: TestAccBatchJobQueue_priority (167.75s)
=== CONT  TestAccBatchJobQueue_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccBatchJobQueue_ComputeEnvironmentOrder_multiple (168.41s)
=== CONT  TestAccBatchJobQueue_disappears
--- PASS: TestAccBatchJobQueue_tags_IgnoreTags_Overlap_DefaultTag (157.51s)
=== CONT  TestAccBatchJobQueue_basic
--- PASS: TestAccBatchJobQueue_disappears (126.26s)
=== CONT  TestAccBatchJobQueue_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccBatchJobQueue_basic (132.15s)
=== CONT  TestAccBatchJobQueue_tags
--- PASS: TestAccBatchJobQueue_tags_IgnoreTags_Overlap_ResourceTag (149.95s)
=== CONT  TestAccBatchJobQueue_tags_EmptyMap
--- PASS: TestAccBatchJobQueue_tags (166.42s)
=== CONT  TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccBatchJobQueue_tags_EmptyMap (131.84s)
=== CONT  TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Add (164.80s)
=== CONT  TestAccBatchJobQueue_tags_ComputedTag_OnCreate
--- PASS: TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Replace (145.32s)
=== CONT  TestAccBatchJobQueue_tags_null
--- PASS: TestAccBatchJobQueue_tags_ComputedTag_OnCreate (136.28s)
--- PASS: TestAccBatchJobQueue_tags_null (131.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/batch	2382.990s
% TF_ACC=1 make testacc TESTS=TestAccEventsTarget_batch PKG=events                                                                                                                
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsTarget_batch'  -timeout 360m
2025/01/02 15:00:34 Initializing Terraform AWS Provider...
=== RUN   TestAccEventsTarget_batch
=== PAUSE TestAccEventsTarget_batch
=== CONT  TestAccEventsTarget_batch
--- PASS: TestAccEventsTarget_batch (136.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	140.333s
% TF_ACC=1 make testacc TESTS=TestAccPipesPipe_sqsSourceBatchJobTarget PKG=pipes                                                                                                  <aws:provider> <region:us-east-2>
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/pipes/... -v -count 1 -parallel 20 -run='TestAccPipesPipe_sqsSourceBatchJobTarget'  -timeout 360m
2025/01/02 15:07:55 Initializing Terraform AWS Provider...
=== RUN   TestAccPipesPipe_sqsSourceBatchJobTarget
=== PAUSE TestAccPipesPipe_sqsSourceBatchJobTarget
=== CONT  TestAccPipesPipe_sqsSourceBatchJobTarget
--- PASS: TestAccPipesPipe_sqsSourceBatchJobTarget (159.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/pipes	163.286s

@danquack danquack requested a review from a team as a code owner January 2, 2025 20:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/batch Issues and PRs that pertain to the batch service. service/events Issues and PRs that pertain to the events service. service/pipes Issues and PRs that pertain to the pipes service. needs-triage Waiting for first response or review from a maintainer. labels Jan 2, 2025
@danquack danquack force-pushed the 39568/migrate-compute-environment branch from 4e08da4 to bf8c04d Compare January 2, 2025 21:25
@drewmullen drewmullen added this to the v6.0.0 milestone Jan 6, 2025
@drewmullen drewmullen added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Jan 6, 2025
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/batch Issues and PRs that pertain to the batch service. service/events Issues and PRs that pertain to the events service. service/pipes Issues and PRs that pertain to the pipes service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v6.0.0
3 participants
@danquack @ewbankkit @drewmullen