Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Converts conns.AWSClient DefaultTagsConfig to function and adds transparent tagging to several data sources #39658

Merged
merged 21 commits into from
Oct 15, 2024
Merged

provider: Converts conns.AWSClient DefaultTagsConfig to function and adds transparent tagging to several data sources #39658

merged 21 commits into from
Oct 15, 2024

Conversation

gdavison
Copy link
Contributor

Description

Converts conns.AWSClient DefaultTagsConfig to function and adds transparent tagging to several data sources. Adds tagging tests as needed

@gdavison gdavison requested a review from a team as a code owner October 10, 2024 01:13
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. service/s3 Issues and PRs that pertain to the s3 service. service/ecs Issues and PRs that pertain to the ecs service. service/elasticache Issues and PRs that pertain to the elasticache service. provider Pertains to the provider itself, rather than any interaction with AWS. service/datapipeline Issues and PRs that pertain to the datapipeline service. service/fsx Issues and PRs that pertain to the fsx service. service/quicksight Issues and PRs that pertain to the quicksight service. service/sesv2 Issues and PRs that pertain to the sesv2 service. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) service/dms Issues and PRs that pertain to the dms service. service/meta Issues and PRs that pertain to the meta service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 10, 2024
@gdavison gdavison force-pushed the td-tftags-settagsdiff branch from 45c062b to a252a62 Compare October 10, 2024 18:09
ewbankkit
ewbankkit approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Sample acceptance test:

% make testacc TESTARGS='-run=TestAccDMSEndpointDataSource_' PKG=dms ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/dms/... -v -count 1 -parallel 2  -run=TestAccDMSEndpointDataSource_ -timeout 360m
2024/10/11 11:22:38 Initializing Terraform AWS Provider...
=== RUN   TestAccDMSEndpointDataSource_tags
=== PAUSE TestAccDMSEndpointDataSource_tags
=== RUN   TestAccDMSEndpointDataSource_tags_NullMap
=== PAUSE TestAccDMSEndpointDataSource_tags_NullMap
=== RUN   TestAccDMSEndpointDataSource_tags_EmptyMap
=== PAUSE TestAccDMSEndpointDataSource_tags_EmptyMap
=== RUN   TestAccDMSEndpointDataSource_basic
=== PAUSE TestAccDMSEndpointDataSource_basic
=== CONT  TestAccDMSEndpointDataSource_tags
=== CONT  TestAccDMSEndpointDataSource_tags_EmptyMap
--- PASS: TestAccDMSEndpointDataSource_tags (18.88s)
=== CONT  TestAccDMSEndpointDataSource_basic
--- PASS: TestAccDMSEndpointDataSource_tags_EmptyMap (18.96s)
=== CONT  TestAccDMSEndpointDataSource_tags_NullMap
--- PASS: TestAccDMSEndpointDataSource_tags_NullMap (24.69s)
--- PASS: TestAccDMSEndpointDataSource_basic (25.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	49.753s

@gdavison gdavison merged commit 4691dea into main Oct 15, 2024
41 checks passed
@gdavison gdavison deleted the td-tftags-settagsdiff branch October 15, 2024 18:54
@github-actions github-actions bot added this to the v5.72.0 milestone Oct 15, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 15, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/datapipeline Issues and PRs that pertain to the datapipeline service. service/dms Issues and PRs that pertain to the dms service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecs Issues and PRs that pertain to the ecs service. service/elasticache Issues and PRs that pertain to the elasticache service. service/fsx Issues and PRs that pertain to the fsx service. service/meta Issues and PRs that pertain to the meta service. service/quicksight Issues and PRs that pertain to the quicksight service. service/s3 Issues and PRs that pertain to the s3 service. service/sesv2 Issues and PRs that pertain to the sesv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.)
Projects
None yet
Milestone
v5.72.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @ewbankkit