Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add aws_media_packagev2_channel_group resource #38406

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

add aws_media_packagev2_channel_group resource #38406

wants to merge 11 commits into from
+3,241 −1

Conversation

mattyboy84
Copy link

Description

Adds the aws_media_packagev2_channel_group resource which creates an AWS Elemental Media Package V2 Channel Group.

Relations

Closes #38404

Output from Acceptance Testing

=== RUN   TestAccMediaPackageV2_serial
=== PAUSE TestAccMediaPackageV2_serial
=== CONT  TestAccMediaPackageV2_serial
=== RUN   TestAccMediaPackageV2_serial/MediaPackageChannelGroup
=== RUN   TestAccMediaPackageV2_serial/MediaPackageChannelGroup/basic
=== RUN   TestAccMediaPackageV2_serial/MediaPackageChannelGroup/description
=== RUN   TestAccMediaPackageV2_serial/MediaPackageChannelGroup/disappears
=== RUN   TestAccMediaPackageV2_serial/MediaPackageChannelGroup/tags
--- PASS: TestAccMediaPackageV2_serial (53.11s)
    --- PASS: TestAccMediaPackageV2_serial/MediaPackageChannelGroup (53.11s)
        --- PASS: TestAccMediaPackageV2_serial/MediaPackageChannelGroup/basic (10.29s)
        --- PASS: TestAccMediaPackageV2_serial/MediaPackageChannelGroup/description (14.54s)
        --- PASS: TestAccMediaPackageV2_serial/MediaPackageChannelGroup/disappears (7.97s)
        --- PASS: TestAccMediaPackageV2_serial/MediaPackageChannelGroup/tags (20.32s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mediapackagev2    94.667s

@mattyboy84 mattyboy84 requested a review from a team as a code owner July 18, 2024 07:11
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. tags Pertains to resource tagging. generators Relates to code generators. service/mediapackagev2 Issues and PRs that pertain to the mediapackagev2 service. size/XL Managed by automation to categorize the size of a PR. labels Jul 18, 2024
github-actions[bot]
github-actions bot reviewed Jul 18, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @mattyboy84 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added the new-resource Introduces a new resource. label Jul 22, 2024
johnsonaj
johnsonaj approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=TestAccMediaPackageV2_serial/ChannelGroup/' PKG=mediapackagev2

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/mediapackagev2/... -v -count 1 -parallel 20  -run=TestAccMediaPackageV2_serial/ChannelGroup/ -timeout 360m
2025/01/09 16:38:01 Initializing Terraform AWS Provider...
--- PASS: TestAccMediaPackageV2_serial (602.94s)
    --- PASS: TestAccMediaPackageV2_serial/ChannelGroup (602.94s)
        --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/basic (13.81s)
        --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/description (21.29s)
        --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/disappears (11.34s)
        --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags (556.50s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/EmptyTag_OnUpdate_Add (34.08s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/ComputedTag_OnCreate (16.97s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/ComputedTag_OnUpdate_Replace (25.33s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/IgnoreTags_Overlap_ResourceTag (33.67s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/EmptyTag_OnCreate (26.30s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_nonOverlapping (37.96s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_updateToResourceOnly (22.21s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_nullOverlappingResourceTag (14.43s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_nullNonOverlappingResourceTag (14.46s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/IgnoreTags_Overlap_DefaultTag (29.30s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_providerOnly (49.36s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/AddOnUpdate (22.72s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_updateToProviderOnly (22.96s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_emptyResourceTag (14.35s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/null (13.90s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/EmptyMap (13.99s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/EmptyTag_OnUpdate_Replace (22.53s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_overlapping (37.46s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/ComputedTag_OnUpdate_Add (56.44s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/basic (48.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mediapackagev2	609.288s

ewbankkit
ewbankkit approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccMediaPackageV2_serial/^ChannelGroup$$' PKG=mediapackagev2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/mediapackagev2/... -v -count 1 -parallel 20  -run=TestAccMediaPackageV2_serial/^ChannelGroup$ -timeout 360m
2025/01/10 09:51:01 Initializing Terraform AWS Provider...
=== RUN   TestAccMediaPackageV2_serial
=== PAUSE TestAccMediaPackageV2_serial
=== CONT  TestAccMediaPackageV2_serial
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/description
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/disappears
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/tags
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/tags/basic
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/tags/EmptyMap
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/tags/EmptyTag_OnCreate
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/tags/ComputedTag_OnCreate
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/tags/ComputedTag_OnUpdate_Replace
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/tags/IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/tags/null
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/tags/EmptyTag_OnUpdate_Add
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/tags/EmptyTag_OnUpdate_Replace
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_providerOnly
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_nonOverlapping
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_updateToProviderOnly
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_updateToResourceOnly
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/tags/IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/tags/AddOnUpdate
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_overlapping
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_emptyResourceTag
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/tags/ComputedTag_OnUpdate_Add
=== RUN   TestAccMediaPackageV2_serial/ChannelGroup/basic
--- PASS: TestAccMediaPackageV2_serial (547.46s)
    --- PASS: TestAccMediaPackageV2_serial/ChannelGroup (547.46s)
        --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/description (20.80s)
        --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/disappears (11.57s)
        --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags (502.42s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/basic (44.86s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/EmptyMap (13.28s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/EmptyTag_OnCreate (23.89s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_nullOverlappingResourceTag (13.45s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_nullNonOverlappingResourceTag (13.36s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/ComputedTag_OnCreate (17.96s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/ComputedTag_OnUpdate_Replace (26.01s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/IgnoreTags_Overlap_DefaultTag (27.85s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/null (13.45s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/EmptyTag_OnUpdate_Add (33.41s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/EmptyTag_OnUpdate_Replace (21.76s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_providerOnly (46.71s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_nonOverlapping (36.13s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_updateToProviderOnly (21.28s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_updateToResourceOnly (21.09s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/IgnoreTags_Overlap_ResourceTag (30.01s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/AddOnUpdate (22.02s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_overlapping (36.07s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/DefaultTags_emptyResourceTag (13.67s)
            --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/tags/ComputedTag_OnUpdate_Add (26.14s)
        --- PASS: TestAccMediaPackageV2_serial/ChannelGroup/basic (12.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mediapackagev2	553.067s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@johnsonaj johnsonaj johnsonaj approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/mediapackagev2 Issues and PRs that pertain to the mediapackagev2 service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New]: aws_media_packagev2_channel_group
5 participants
@mattyboy84 @ewbankkit @johnsonaj @justinretzolk @mhh611