chore(deps): update dependencies #3797
Open
+38
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in particular remove tmccombs/hcl2json replacement cdktf/hcl2json and update the library as the issues are now fixed Solves: hashicorp#3793
|
|
uluzox
requested review from
mutahhir and
DanielMSchmidt
and removed request for
a team
DanielMSchmidt
approved these changes
Jan 6, 2025
|
I think this currently prevents the build to succeed |
I updated the PR and also set toolchain to Go Version without the patch part of the semantic version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in particular remove tmccombs/hcl2json replacement cdktf/hcl2json and update the library as the issues are now fixed
Solves: #3793
Related issue
Fixes #3793
Description
Dependency https://github.com/tmccombs/hcl2json was replaced with github.com/cdktf/hcl2json
https://github.com/hashicorp/terraform-cdk/blob/c1ca5b3896b2751a7297da97a1bd9eb10d2ffddf/packages/%40cdktf/hcl2json/go.mod#L11C48-L11C73
in order to correctly keep escape sequences for interpolations in template expressions
tmccombs/hcl2json@cc85d3b
This was now fixed in tmccombs/hcl2json#96 thus the original library could be used.
Also v0.6.5 of the library probably solves parsing provider functions tmccombs/hcl2json#110
Checklist