Fix: Inaccurate Memory Resource Example

[robert-c-ewing]

Description

Fix: Inaccurate Memory Resource Example

Nomad memory sizes are always in binary units (plenty of places with e.g. MemoryMB * 1024 * 1024 around the codebase). This snippet of documentation, however, is misleading, and implies that Nomad manages/tracks memory with decimal units.

Without going crazy changing "MB"->"MiB" everywhere, causing mass confusion and horrid edit wars, let's just change this one number! This is a subtle but effective way to signal to developers that we're using binary-based sizes.

(Even if this argument fails, this documentation is plain wrong: MemoryMB = 2000 will use ~2.1GB: 2000 binary megabytes, 1048576 bytes each.)

Testing & Reproduction steps

N/A

Links

Example of size computation in Docker driver, clearly computing mibibytes

Contributor Checklist

• Changelog Entry If this PR changes user-facing behavior, please generate and add a
  changelog entry using the make cl command.
• Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
  ensure regressions will be caught.
• Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
  and job configuration, please update the Nomad website documentation to reflect this. Refer to
  the website README for docs guidelines. Please also consider whether the
  change requires notes within the upgrade guide.

Reviewer Checklist

• Backport Labels Please add the correct backport labels as described by the internal
  backporting document.
• Commit Type Ensure the correct merge method is selected which should be "squash and merge"
  in the majority of situations. The main exceptions are long-lived feature branches or merges where
  history should be preserved.
• Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
  within the public repository.

[hashicorp-cla-app]

All committers have signed the CLA.

[hashicorp-cla-app]

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

_{Have you signed the CLA already but the status is still pending? Recheck it.}

[aimeeu]

Thanks for addressing this. Looks like this slipped in over 5 years ago.