docker: respect image_pull_timeout #24991
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gulducat
added
type/bug
theme/driver/docker
backport/1.9.x
gulducat
force-pushed
the
b-docker-image_pull_timeout
branch
from
42c82d0 to
29ce922
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the
dockerdriver stopped respecting image_pull_timeout in Nomad1.9.0in this refactor.This makes the timeout apply again. There is some risk that folks are unwittingly depending on the timeout not working (it is a generous 5 minutes by default), but since it has only been this way since
1.9(as far as I can tell), the exposure is somewhat limited.The different
contexts around here are pretty confusing. I hope I got them right, and left informative enough var names and comments to help future folks keep them straight.This PR extends #24981, which makes
recoverablePullError()properly wrap the passed error (such as a context timeout).