Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of NET-6878: Fix Flake API Gateway Acceptance into release/1.3.x #3727

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #3717 to be assessed for backporting due to the inclusion of the label backport/1.3.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@NiniOak
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul-k8s/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Changes proposed in this PR

  • Upgraded some out of date libraries
  • Terratest library/function introduced the flaky behaviour observered in K8s acceptance tests, it was replaced with exec.Command() inbuilt GoFunc

How I've tested this PR

Ran test locally >20times
CI passes consecutively

How I expect reviewers to test this PR

See CI history for this branch

Checklist


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/NET-6878_fix_flaky_tests/likely-square-crappie branch from f7dce15 to accd22d Compare March 8, 2024 17:29
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 8, 2024

CLA assistant check
All committers have signed the CLA.

@NiniOak NiniOak force-pushed the backport/NET-6878_fix_flaky_tests/likely-square-crappie branch from 9d7798a to 4f3329c Compare March 8, 2024 18:01
@NiniOak NiniOak marked this pull request as ready for review March 8, 2024 18:01
@NiniOak NiniOak enabled auto-merge (squash) March 8, 2024 18:01
@NiniOak NiniOak merged commit 3e99d3b into release/1.3.x Mar 8, 2024
25 of 50 checks passed
@NiniOak NiniOak deleted the backport/NET-6878_fix_flaky_tests/likely-square-crappie branch March 8, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants