Package Cache Concurrency #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we run checkValidVersionString, version will never be null, and can be final. Also, everything else can be final.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1715 +/- ##
============================================
+ Coverage 12.49% 12.53% +0.04%
- Complexity 32244 32348 +104
============================================
Files 2203 2204 +1
Lines 673803 674085 +282
Branches 198653 198715 +62
============================================
+ Hits 84181 84498 +317
+ Misses 559653 559533 -120
- Partials 29969 30054 +85 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reworks concurrency in the FileSystemPackageCacheManager.
Expanding on the test originally outlined in #1641, this adds a centralized series of locks that takes into account the lifecycle of the FileSystemPackageCacheManager and packages (creation, clear, package delete, etc), and provides additional utilities to ensure that all validation engines are using the same locks.