Skip to content

Commit

Permalink
JBEAP-5139: Consolidate and make comments in POM files more consistent
Browse files Browse the repository at this point in the history
  • Loading branch information
sgilda committed Jul 27, 2016
1 parent 44eda52 commit 544c63c
Show file tree
Hide file tree
Showing 106 changed files with 358 additions and 474 deletions.
5 changes: 3 additions & 2 deletions app-client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,9 @@
</pluginRepositories>

<properties>
<!-- Explicitly declaring the source encoding eliminates the following message: -->
<!-- [WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent! -->
<!-- Explicitly declaring the source encoding eliminates the following
message: [WARNING] Using platform encoding (UTF-8 actually) to copy
filtered resources, i.e. build is platform dependent! -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<!-- EAP component version management BOM -->
Expand Down
16 changes: 7 additions & 9 deletions batch-processing/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,9 @@

<properties>
<!-- Explicitly declaring the source encoding eliminates the following
message: -->
<!-- [WARNING] Using platform encoding (UTF-8 actually) to copy filtered
resources, i.e. build is platform dependent! -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
message: [WARNING] Using platform encoding (UTF-8 actually) to copy
filtered resources, i.e. build is platform dependent! -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<!-- JBoss dependency versions -->
<version.wildfly.maven.plugin>1.0.2.Final</version.wildfly.maven.plugin>
Expand Down Expand Up @@ -190,9 +189,9 @@
<scope>provided</scope>
</dependency>

<!-- Bean Validation Implementation -->
<!-- Provides portable constraints such as @Email -->
<!-- Hibernate Validator is shipped in JBoss EAP -->
<!-- Bean Validation Implementation
Provides portable constraints such as @Email
Hibernate Validator is shipped in JBoss EAP -->
<dependency>
<groupId>org.hibernate</groupId>
<artifactId>hibernate-validator</artifactId>
Expand Down Expand Up @@ -240,8 +239,7 @@
</dependencies>

<build>
<!-- Maven will append the version to the finalName (which is the name
given to the generated WAR, and hence the context root) -->
<!-- Set the name of the WAR, used as the context root when the app is deployed -->
<finalName>${project.artifactId}</finalName>
<plugins>
<plugin>
Expand Down
9 changes: 4 additions & 5 deletions bean-validation-custom-constraint/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,9 @@
<scope>provided</scope>
</dependency>

<!-- Bean Validation Implementation -->
<!-- Provides portable constraints such as @Email -->
<!-- Hibernate Validator is shipped in JBoss EAP -->
<!-- Bean Validation Implementation
Provides portable constraints such as @Email
Hibernate Validator is shipped in JBoss EAP -->
<dependency>
<groupId>org.hibernate</groupId>
<artifactId>hibernate-validator</artifactId>
Expand Down Expand Up @@ -194,8 +194,7 @@
</dependencies>

<build>
<!-- Maven will append the version to the finalName (which is the name
given to the generated WAR, and hence the context root) -->
<!-- Set the name of the WAR, used as the context root when the app is deployed -->
<finalName>${project.artifactId}</finalName>

<!-- Define plug-in versions required for Deployment and Testing Tools -->
Expand Down
9 changes: 4 additions & 5 deletions bean-validation/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,9 @@
<scope>provided</scope>
</dependency>

<!-- Bean Validation Implementation -->
<!-- Provides portable constraints such as @Email -->
<!-- Hibernate Validator is shipped in JBoss EAP -->
<!-- Bean Validation Implementation
Provides portable constraints such as @Email
Hibernate Validator is shipped in JBoss EAP -->
<dependency>
<groupId>org.hibernate</groupId>
<artifactId>hibernate-validator</artifactId>
Expand Down Expand Up @@ -194,8 +194,7 @@
</dependencies>

<build>
<!-- Maven will append the version to the finalName (which is the name
given to the generated WAR, and hence the context root) -->
<!-- Set the name of the WAR, used as the context root when the app is deployed -->
<finalName>${project.artifactId}</finalName>

<!-- Define plug-in versions required for Deployment and Testing Tools -->
Expand Down
8 changes: 3 additions & 5 deletions bmt/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,8 @@

<properties>
<!-- Explicitly declaring the source encoding eliminates the following
message: -->
<!-- [WARNING] Using platform encoding (UTF-8 actually) to copy filtered
resources, i.e. build is platform dependent! -->
message: [WARNING] Using platform encoding (UTF-8 actually) to copy
filtered resources, i.e. build is platform dependent! -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<!-- JBoss dependency versions -->
Expand Down Expand Up @@ -177,8 +176,7 @@
</dependencies>

<build>
<!-- Set the name of the WAR, used as the context root when the app
is deployed -->
<!-- Set the name of the WAR, used as the context root when the app is deployed -->
<finalName>${project.artifactId}</finalName>
<plugins>
<plugin>
Expand Down
12 changes: 4 additions & 8 deletions cdi-alternative/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,9 @@
The pom builds the web WAR artifact.
-->
<properties>
<!-- Explicitly declaring the source encoding eliminates the following message: -->
<!-- [WARNING] Using platform encoding (UTF-8 actually) to copy filtered
resources, i.e. build is platform dependent! -->
<!-- Explicitly declaring the source encoding eliminates the following
message: [WARNING] Using platform encoding (UTF-8 actually) to copy
filtered resources, i.e. build is platform dependent! -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<!-- JBoss dependency versions -->
Expand All @@ -115,9 +115,6 @@

<dependencyManagement>
<dependencies>
<!-- Define the version of the JBoss Java EE APIs we want to import.
Any dependencies from org.jboss.spec will have their version defined by this
BOM -->
<!-- JBoss distributes a complete set of Java EE APIs including
a Bill of Materials (BOM). A BOM specifies the versions of a "stack" (or
a collection) of artifacts. We use this here so that we always get the correct
Expand Down Expand Up @@ -155,8 +152,7 @@
</dependencies>

<build>
<!-- Set the name of the WAR, used as the context root when the app
is deployed -->
<!-- Set the name of the WAR, used as the context root when the app is deployed -->
<finalName>${project.artifactId}</finalName>
<plugins>
<plugin>
Expand Down
10 changes: 4 additions & 6 deletions cdi-decorator/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,9 @@
<!-- The pom builds the web WAR artifact. -->
<properties>
<!-- Explicitly declaring the source encoding eliminates the following
message: -->
<!-- [WARNING] Using platform encoding (UTF-8 actually) to copy filtered
resources, i.e. build is platform dependent! -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
message: [WARNING] Using platform encoding (UTF-8 actually) to copy
filtered resources, i.e. build is platform dependent! -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<!-- JBoss dependency versions -->

Expand Down Expand Up @@ -146,8 +145,7 @@
</dependencies>

<build>
<!-- Set the name of the WAR, used as the context root when the app is
deployed -->
<!-- Set the name of the WAR, used as the context root when the app is deployed -->
<finalName>${project.artifactId}</finalName>
<plugins>
<plugin>
Expand Down
6 changes: 3 additions & 3 deletions cdi-injection/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,9 @@
</pluginRepositories>

<properties>
<!-- Explicitly declaring the source encoding eliminates the following message: -->
<!-- [WARNING] Using platform encoding (UTF-8 actually) to copy filtered
resources, i.e. build is platform dependent! -->
<!-- Explicitly declaring the source encoding eliminates the following
message: [WARNING] Using platform encoding (UTF-8 actually) to copy
filtered resources, i.e. build is platform dependent! -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<!-- JBoss dependency versions -->
Expand Down
8 changes: 3 additions & 5 deletions cdi-interceptors/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,8 @@

<properties>
<!-- Explicitly declaring the source encoding eliminates the following
message: -->
<!-- [WARNING] Using platform encoding (UTF-8 actually) to copy filtered
resources, i.e. build is platform dependent! -->
message: [WARNING] Using platform encoding (UTF-8 actually) to copy
filtered resources, i.e. build is platform dependent! -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<!-- JBoss dependency versions -->
Expand Down Expand Up @@ -189,8 +188,7 @@
</dependencies>

<build>
<!-- Set the name of the WAR, used as the context root when the app is
deployed -->
<!-- Set the name of the WAR, used as the context root when the app is deployed -->
<finalName>${project.artifactId}</finalName>
<plugins>
<plugin>
Expand Down
1 change: 1 addition & 0 deletions cdi-portable-extension/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@
</dependencies>

<build>
<!-- Set the name of the WAR, used as the context root when the app is deployed -->
<finalName>${project.artifactId}</finalName>
<plugins>
<plugin>
Expand Down
8 changes: 3 additions & 5 deletions cdi-stereotype/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,8 @@

<properties>
<!-- Explicitly declaring the source encoding eliminates the following
message: -->
<!-- [WARNING] Using platform encoding (UTF-8 actually) to copy filtered
resources, i.e. build is platform dependent! -->
message: [WARNING] Using platform encoding (UTF-8 actually) to copy
filtered resources, i.e. build is platform dependent! -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<!-- JBoss dependency versions -->
Expand Down Expand Up @@ -171,8 +170,7 @@
</dependencies>

<build>
<!-- Set the name of the WAR, used as the context root when the app is
deployed -->
<!-- Set the name of the WAR, used as the context root when the app is deployed -->
<finalName>${project.artifactId}</finalName>
<plugins>
<plugin>
Expand Down
8 changes: 4 additions & 4 deletions cdi-veto/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,10 @@
</pluginRepositories>

<properties>
<!-- Explicitly declaring the source encoding eliminates the following message:
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered
resources, i.e. build is platform dependent! -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<!-- Explicitly declaring the source encoding eliminates the following
message: [WARNING] Using platform encoding (UTF-8 actually) to copy
filtered resources, i.e. build is platform dependent! -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<!-- JBoss dependency versions -->

Expand Down
6 changes: 3 additions & 3 deletions cluster-ha-singleton/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,9 @@
</pluginRepositories>

<properties>
<!-- Explicitly declaring the source encoding eliminates the following message: -->
<!-- [WARNING] Using platform encoding (UTF-8 actually) to copy filtered
resources, i.e. build is platform dependent! -->
<!-- Explicitly declaring the source encoding eliminates the following
message: [WARNING] Using platform encoding (UTF-8 actually) to copy
filtered resources, i.e. build is platform dependent! -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<!-- EAP component version management BOM -->
Expand Down
2 changes: 1 addition & 1 deletion cluster-ha-singleton/service/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
</dependencies>

<build>
<!-- Specify the artifact name -->
<!-- Specify the archive name -->
<finalName>${project.artifactId}</finalName>
<plugins>
<plugin>
Expand Down
8 changes: 3 additions & 5 deletions cmt/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,8 @@

<properties>
<!-- Explicitly declaring the source encoding eliminates the following
message: -->
<!-- [WARNING] Using platform encoding (UTF-8 actually) to copy filtered
resources, i.e. build is platform dependent! -->
message: [WARNING] Using platform encoding (UTF-8 actually) to copy
filtered resources, i.e. build is platform dependent! -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<!-- JBoss dependency versions -->
Expand Down Expand Up @@ -178,8 +177,7 @@
</dependencies>

<build>
<!-- Maven will append the version to the finalName (which is the
name given to the generated WAR, and hence the context root) -->
<!-- Set the name of the WAR, used as the context root when the app is deployed -->
<finalName>${project.artifactId}</finalName>
<plugins>
<plugin>
Expand Down
5 changes: 2 additions & 3 deletions contacts-jquerymobile/functional-tests/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,8 @@

<properties>
<!-- Explicitly declaring the source encoding eliminates the following
message: -->
<!-- [WARNING] Using platform encoding (UTF-8 actually) to copy filtered
resources, i.e. build is platform dependent! -->
message: [WARNING] Using platform encoding (UTF-8 actually) to copy
filtered resources, i.e. build is platform dependent! -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<!-- To disable warning of missing beans.xml file in JBoss Tools -->
Expand Down
14 changes: 7 additions & 7 deletions contacts-jquerymobile/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,9 @@
</pluginRepositories>

<properties>
<!-- Explicitly declaring the source encoding eliminates the following message: -->
<!-- [WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent! -->
<!-- Explicitly declaring the source encoding eliminates the following
message: [WARNING] Using platform encoding (UTF-8 actually) to copy
filtered resources, i.e. build is platform dependent! -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<!-- You can reference property in pom.xml or filtered resources (must enable third-party plug-in if using Maven < 2.1) -->
Expand Down Expand Up @@ -199,9 +200,9 @@
<scope>provided</scope>
</dependency>

<!-- Bean Validation Implementation -->
<!-- Provides portable constraints such as @Email -->
<!-- Hibernate Validator is shipped in JBoss -->
<!-- Bean Validation Implementation
Provides portable constraints such as @Email
Hibernate Validator is shipped in JBoss EAP -->
<dependency>
<groupId>org.hibernate</groupId>
<artifactId>hibernate-validator</artifactId>
Expand Down Expand Up @@ -269,8 +270,7 @@
</dependencies>

<build>
<!-- Maven will append the version to the finalName (which is the name given to the generated WAR, and hence the context
root) -->
<!-- Set the name of the WAR, used as the context root when the app is deployed -->
<finalName>${project.artifactId}</finalName>
<plugins>
<!-- This skips all tests, though you can tune it to run just unit tests based on a custom pattern -->
Expand Down
5 changes: 2 additions & 3 deletions ejb-asynchronous/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,8 @@

<properties>
<!-- Explicitly declaring the source encoding eliminates the following
message: -->
<!-- [WARNING] Using platform encoding (UTF-8 actually) to copy filtered
resources, i.e. build is platform dependent! -->
message: [WARNING] Using platform encoding (UTF-8 actually) to copy
filtered resources, i.e. build is platform dependent! -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<!-- EAP component version management BOM -->
Expand Down
8 changes: 4 additions & 4 deletions ejb-in-ear/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,10 @@
</pluginRepositories>

<properties>
<!-- Explicitly declaring the source encoding eliminates the following message: -->
<!-- [WARNING] Using platform encoding (UTF-8 actually) to copy filtered
resources, i.e. build is platform dependent! -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<!-- Explicitly declaring the source encoding eliminates the following
message: [WARNING] Using platform encoding (UTF-8 actually) to copy
filtered resources, i.e. build is platform dependent! -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<!-- EAP component version management BOM -->
<version.jboss.bom.eap>7.0.0-build-12</version.jboss.bom.eap>
Expand Down
Loading

0 comments on commit 544c63c

Please sign in to comment.