Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added McWorks to the landingpage #32

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

ParsaYadollahi
Copy link
Collaborator

@ParsaYadollahi ParsaYadollahi commented Sep 24, 2020

Added McWorks as upcoming in the landingpage
Screen Shot 2020-09-25 at 5 01 15 PM

@hanidamlaj
Copy link
Owner

-I think your branch is outdated, please pull or rebase from master and resolve merge conflicts.
-Picture resolution is a bit off in 'Internship Postings' section, consider a fixed aspect ratio or height & width.

Screen Shot 2020-09-26 at 11 11 35 PM

@ParsaYadollahi
Copy link
Collaborator Author

Fixed the image & merge conflicts
Screen Shot 2020-09-29 at 12 28 53 AM

@@ -0,0 +1,8 @@
{
"trailingComma": "all",
"tabWidth": 2,
Copy link
Owner

@hanidamlaj hanidamlaj Oct 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Prefer to keep the tab width to the default of value 8.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it to tab width of 8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants