Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support profiling #250

Merged
merged 2 commits into from
Mar 28, 2024
Merged

feat: support profiling #250

merged 2 commits into from
Mar 28, 2024

Conversation

nrwiersma
Copy link
Member

This adds profiling support via Pyroscope.

Copy link
Contributor

@Ullaakut Ullaakut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicks, otherwise LGTM

Name: FlagProfilingDSN,
Usage: "The address an configuration of the Pyroscope server, in the format " +
"'http://basic:auth@server:port?token=auth-token&tenantid=tenant-id'.",
EnvVars: []string{"PROFILING_DSN"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use strcase.ToSNAKE ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current version doesn't at the moment, but the next major will.

Co-authored-by: Brendan Le Glaunec <[email protected]>
@nrwiersma nrwiersma merged commit 3be94cf into main Mar 28, 2024
3 checks passed
@nrwiersma nrwiersma deleted the profiling branch March 28, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants