Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add handling to skip block data in Decoder readBlock method #492

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

lukrah
Copy link
Contributor

@lukrah lukrah commented Jan 23, 2025

Issue is with files having no data (file attached in zip)
File is from Google Cloud Platform.

empty_set.zip

Copy link
Member

@nrwiersma nrwiersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my understanding, what is the use case for the a block with a no count but a size?

ocf/ocf.go Outdated Show resolved Hide resolved
@lukrah
Copy link
Contributor Author

lukrah commented Jan 23, 2025

Just for my understanding, what is the use case for the a block with a no count but a size?

I have no idea why. This is file that google cloud produces.
We check if file has no parsing error and we need to distinguish between empty and invalid files.

@nrwiersma
Copy link
Member

I have no idea why. This is file that google cloud produces.

That is truly bizarre.

@nrwiersma nrwiersma merged commit 4ba9c73 into hamba:main Jan 24, 2025
13 checks passed
@lukrah
Copy link
Contributor Author

lukrah commented Jan 24, 2025

Thank you @nrwiersma. For this library and for support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants