Improved wifi pw to discord script #511
Conversation
|
if you merge it, please change the is.gd link please, so it no longer leads to my repo, instead please put something like YOUR_PS_SCRIPT_LINK_HERE in. thx |
|
We do not allow stripping credits from authors, Please restore original authors name. Changes made to anther authors payload requires review and approval from the original author. @aleff-github |
hak5peaks
added
pending requested changes
|
@hak5peaks I basically changed the Full Code, can i just create a new Payload with my Code? or is it ok for you @aleff-github if i change the Credits to mine or put both or Names in? |
|
The changes made are remarkable, good job. Generally I am pushed to support either without getting credit for the support given or by proposing to add myself to the names of those who developed. But I realize this is my point of view and you may not agree. Since you have made a lot of innovations probably the ideal thing would be to upload a payload named for example “WLAN-Windows-Passwords-Discord-Exfiltration 2.0” or if it is okay with you we could add your name to the already existing payload also changing the version of the script itself to 2.0. Of course in that case you could write down in detail what you did in the README.md file so we can take full credit on what you proposed. Let me know what you think |
Some guys on the Discord told me it would be better if i just made my own payload. So i opened a new Pull Request #512 But i think for the users it will probably be better if they dont have multiple Wifi Password Stealer Payloads. For me it would also be ok if we just credit us both and say who did what. Should we just ask the Moderators what they would prefer @aleff-github ? (and thanks : ) ) |
|
Ultimately the decision is up to @aleff-github as its his payload. however I believe the best is to keep it 1 payload and add both names as author or add credits. |
I agree, I think the ideal thing is to improve the payload, change the version, add the author, and write in the README the changes so that proper credit is given to those who developed the additional features. The question is, should it also be considered as payload? For payload awards? In my opinion if the changes are major, as in this case, then the creator deserves to have it recognized as a new payload. Also because by doing so, users are stimulated to improve what already exists without saying "I see what already exists so I think about doing something else" and going so far as to say "I'm not inventive but I'm good, I can improve everything that has been done in the past" What do you think? @hak5peaks @truelockmc |
|
@aleff-github For me it would be cool if we just edit the Readme and publish this as newer version. sry if i didnt understand something, what are payload awards? |
@truelockmc I propose you this scheme, let me know what do you think about it
About payload awards: https://hak5.org/pages/payload-awards |
|
@aleff-github yes, that looks good how should we write it? |
@truelockmc Edit the pull request #512 so that a new one does not have to be created. Or if you have difficulty doing that close that one and make a new one. if you encounter any problems let me know |
|
done @hak5peaks @aleff-github What do you think, should i change something? |
I changed the .ps1 script, its now working on every windows machine, not only english ones.
Also it exports the full .xml files now, not only sends the Passwords.
That means you get more Information now and everyone can use the script, but you need to read a few seconds before finding the Password in the Discord Channel / in the File.
I also changed the ducky script a bit, it now takes a bit longer to work but isnt detected by AVs anymore, also it is a few lines shorter and easier to read and less likely to make Errors.
I also changed the Credits to my name < 3 (hehe)
@maintainers : change the is.gd link please, so it no longer leads to my repo, instead please put something like YOUR_PS_SCRIPT_LINK_HERE in
thx and i hope you like it and it gets merged : )