Fixed LOB streaming example thanks to Pablo Zorzoli.

More reliably use correct sqlplus thanks to Honza Pazdziora.


git-svn-id: http://svn.perl.org/modules/dbd-oracle/trunk@2343 50811bd7-b8ce-0310-adc1-d9db26280581

Changes

@@ -4,13 +4,15 @@
   Fixed csform setting for some UTF8 cases.
   Fixed INTERVAL DAY TO SECOND thanks to Honza Pazdziora.
   Fixed undef warnings when connecting with undef $user.
+  Fixed LOB streaming example thanks to Pablo Zorzoli.
 
   Added support for nested cursors in select lists thanks to Charles Jardine.
   Added "Trailing Spaces" section to docs thanks to Michael A Chase.
   Added support for binary floats/doubles thanks to Dennis Box.
 
   Changed "Binding Cursors" docs, clarifying examples thanks to Charles Jardine.
-  Changed Makefile.PL to avoid risk of sqlplus hanging thanks to Mark Dedlow.
+  Changed Makefile.PL to avoid risk of sqlplus hanging thanks to Mark Dedlow,
+    and more reliably use correct sqlplus thanks to Honza Pazdziora.
   Changed Makefile.PL to prefer ~/rdbms/public over other ~/rdbms/* for .h files.
   Changed Makefile.PL to improve build rule detection.
   Changed Makefile.PL to Instant Client build support thanks to Hilmar Lapp.

Makefile.PL

@@ -1433,7 +1433,7 @@ sub get_client_version {
     my $client_version_full = '';
 
     my $sqlplus_exe = ($os eq 'Win32' || $os eq 'MSWin32') ? "sqlplus.exe" : "sqlplus";
-    local $ENV{PATH} = join $Config{path_sep}, $ENV{PATH}, "$OH/bin", $OH;
+    local $ENV{PATH} = join $Config{path_sep}, "$OH/bin", $OH, $ENV{PATH};
     local $ENV{SQLPATH} = ""; # avoid $SQLPATH/login.sql causing sqlplus to hang
     print "path=$ENV{PATH}\n";
     if (find_bin($sqlplus_exe)) {

Oracle.pm

@@ -2379,7 +2379,7 @@ than could be stored in memory at a given time.
    my $offset = 1;   # Offsets start at 1, not 0
    while( my $data = $dbh->ora_lob_read( $char_locator, $offset, $chunk_size ) ) {
       print STDOUT $data;
-      $offset += $length;
+      $offset += $chunk_size;
    }
 
 Notice that the select statement does not contain the phrase