fix(guess): return list instead of odict_keys

`run()` uses subscripted access to the return value, which doesn't work for `odict_keys`.
guludo · Mar 6, 2022 · 99a1ae1 · 99a1ae1
1 parent 9e0ccdc
commit 99a1ae1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,7 +1,7 @@
 # Changelog
 
 ## Unreleased
-- Nothing yet.
+- Fix subscripted access to guessed venvs return value (@scop)
 
 ## 0.1.1 - 2022-02-28
 ### Fixed

diff --git a/src/venvrun.py b/src/venvrun.py
@@ -38,7 +38,7 @@ def guess():
         if os.access(exe, os.X_OK)
     )
 
-    return venvs.keys()
+    return list(venvs.keys())
 
 
 def run():

diff --git a/tests/test_venvrun.py b/tests/test_venvrun.py
@@ -29,6 +29,7 @@ def mock_run(*args, **kwargs):
         with patch.object(venvrun.platform, "system", return_value='Linux'), \
              patch.object(venvrun.subprocess, "run", mock_run):
             venvs = venvrun.guess()
+            self.assertTrue(venvs[0], "subscriptability")
             self.assertListEqual(
                 sorted(venvs),
                 sorted(
@@ -49,6 +50,7 @@ def mock_run(*args, **kwargs):
         with patch.object(venvrun.platform, "system", return_value='Linux'), \
              patch.object(venvrun.subprocess, "run", mock_run):
             venvs = venvrun.guess()
+            self.assertTrue(venvs[0], "subscriptability")
             self.assertListEqual(
                 sorted(venvs),
                 sorted(
@@ -72,6 +74,7 @@ def mock_run(*args, **kwargs):
             with patch.object(venvrun.platform, "system", return_value='Linux'), \
                  patch.object(venvrun.subprocess, "run", mock_run):
                 venvs = venvrun.guess()
+                self.assertTrue(venvs[0], "subscriptability")
                 self.assertListEqual(
                     sorted(venvs),
                     sorted(