-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid Tiling #32
base: main
Are you sure you want to change the base?
Grid Tiling #32
Conversation
this is a great feature, and something I agree needs to be implemented somewhere. Am I correct in understanding that this requires grid members (individual images in a grid) to be shifted exactly a pixel size multiple? and creates a single "virtual" dataset containing all the images? |
class GridPlanTensorStoreHandler(TensorStoreHandler): | ||
def __init__( | ||
self, | ||
sequence: MDASequence, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i made a point of resisting passing a sequence to the handler constructor, with the idea being that handler should be able to deal with multiple sequences (we don't necessarily imply a 1-to-1 mapping of sequence-handler). You can access the currently running sequence via the public TensorStoreHandler.current_sequence
(however, I'm realizing now that it's poorly implemented since it will be an attribute error prior to sequenceStarted
being called).
Ideally, yes, however we'd need to make some API changes to |
correct, that would be a change to ndv |
This PR enables a MDA containing a grid plan to present a tiled view within the viewer.
GridLayoutExample.mp4
It is a draft because it:
TensorStoreHandler
from pymmcore-plus, and overrides a private methodTensorStoreHandler._event_index_to_store_index
, which could be unstable long-term.