Remove locked attribute

[brianburnszd]

According to Datadog docs, locked attribute in monitors is no longer supported.

This PR:

1. Stops sending locked as an attribute when creating monitors
2. No longer diffs locked attribute when comparing monitors against Datadog

Tested out locally and shows the API request to create monitors without locked attr:

{
  "name": "Test Locked attr",
  "tags": ...
  "options": {
    ...
    <no "locked" option>
    }
}

Note that when merged, all existing monitor generated JSON will also loose the locked attribute, but because the diff is a no-op, Datadog will not be updated (what we want).

Checklist

• Verified against local install of kennel (using path: in Gemfile)
• Added tests
• Updated Readme.md (if user facing behavior changed)

[brianburnszd]

This may be a breaking change to anyone using locked: true in monitor configuration. Not sure how this needs to be communicated or if it needs to be noted in a Changelog? Probably requires a major version update?

[grosser]

I'm trying a different approach with putting it into read-only, I'll report back in a bit

…

On Fri, Mar 29, 2024, 9:38 AM Brian Burns ***@***.***> wrote: This may be a breaking change to anyone using locked: true in monitor configuration. Not sure how this needs to be communicated or if it needs to be noted in a Changelog? Probably requires a major version update? — Reply to this email directly, view it on GitHub <#311 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACYZZXBOGCCTQJFOMPIFLY2WDH7AVCNFSM6AAAAABFOUEJQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXGQ3DMMJWGU> . You are receiving this because you commented.Message ID: ***@***.***>

[grosser]

readonly did not work since it's a option and not a top-level attribute

[grosser]

I'll add another small fix and then make zendesk PR