Log / respect rate limits #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
reviewed
Mar 2, 2024
| @@ -5,6 +5,8 @@ module Kennel | |||
| class Api | |||
| CACHE_FILE = ENV.fetch("KENNEL_API_CACHE_FILE", "tmp/cache/details") | |||
|
|
|||
| RateLimitParams = Data.define(:limit, :period, :remaining, :reset, :name) | |||
There was a problem hiding this comment.
feels like you had too much golang for breakfast :D
|
good to just merge right ... any gotchas you expect ? |
I think it's good, I've tested it out a fair bit (e.g. https://github.com/zendesk/kennel/actions/runs/8121811687 and others). If the rate limit hits, then each thread that hits the rate limit will sleep – so typically you'd suddenly see 10 messages (1 per thread) saying "Rate limited, sleeping for [e.g.] 25 seconds". Then they all wake up and try again. |
|
v1.149.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
Checklist
path:in Gemfile)https://github.com/zendesk/kennel/actions/runs/8120685832/job/22198172379#step:7:27