-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(layoutProps): add ColumnLayoutProps to ControlUISchema #94
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
==========================================
+ Coverage 74.70% 74.85% +0.15%
==========================================
Files 38 38
Lines 502 505 +3
Branches 94 96 +2
==========================================
+ Hits 375 378 +3
Misses 90 90
Partials 37 37 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard to wrap my mind around how this works. Can you add a story to HorizontalLayout.stories.tsx?
5abbe66
to
cee2245
Compare
@NathanFarmer It's really more of a change to the Control definition, so I added an "empty" |
cee2245
to
3ddf1f2
Compare
3ddf1f2
to
570d262
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work with multiple columns? That's what I wasn't quite understanding and was expecting to see in the story.
Also, is layoutProps: { columns: undefined }
now required, or did you add them everywhere to make it clear that it's an available prop? If it's required, I would think that it's a breaking change.
Do you intend for this PR to trigger release? If so your PR title should follow conventional commit syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on synchronous conversation
🎉 This PR is included in version 1.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
We need the column spacing to be a bit more flexible in horizontal layouts.
This introduces a
ColumnLayoutProps
andlayoutProps
interface that allows for the specification of column widths on individual HorizontalLayout elements.Without layoutProps
With layoutProps