-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add formItemProps
to UI schemas
#80
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
==========================================
- Coverage 76.60% 75.59% -1.01%
==========================================
Files 36 36
Lines 436 459 +23
Branches 75 85 +10
==========================================
+ Hits 334 347 +13
Misses 78 78
- Partials 24 34 +10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great! I did not functionally validate this. Let me know if that would be helpful. Probably worth getting a second a opinion since I am not familiar with the code base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still reviewing
formItemProps
to UI schemas
…t-expectations/jsonforms-antd-renderers into f/ph-1294/tooltip-in-all-ui-schemas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM--I left a comment on defining ControlProps more clearly in BooelanControl.tsx and similar components, but not gonna block on that. Nice work!
🎉 This PR is included in version 1.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Enables passing a
tooltip
(as well as any other prop) through to AntDForm.Item
via UI schemas.