feat: Primitive array control #49
Conversation
src/controls/ArrayControl.tsx
Outdated
| // Note: For primative arrays, ArrayControlProps.data is an array | ||
| // For object arrays, ArrayLayoutProps.data is a number | ||
| const dataSource: any[] = | ||
| typeof data === "number" | ||
| ? range(data) | ||
| : // antd List component doesn't like undefined/null in the dataSource | ||
| data?.map((item: any) => item ?? "") | ||
| const dataLength = typeof data === "number" ? data : data?.length || 0 | ||
|
|
There was a problem hiding this comment.
This is the main difference for the Object Array vs the Primitive Array
src/controls/ArrayControl.tsx
Outdated
| /* eslint-disable @typescript-eslint/no-explicit-any */ | ||
| /* eslint-disable @typescript-eslint/no-unsafe-call */ | ||
| /* eslint-disable @typescript-eslint/no-unsafe-member-access */ | ||
| /* eslint-disable @typescript-eslint/no-unsafe-return */ | ||
| /* eslint-disable @typescript-eslint/no-unsafe-assignment */ |
There was a problem hiding this comment.
this is a lot of eslint things to disable--did you intend to leave these in?
There was a problem hiding this comment.
Since json-forms has a lot of any types these errors are showing up. Maybe if I'm able to split the component it might be slightly better. Any suggestions?
src/controls/ArrayControl.tsx
Outdated
| @@ -58,6 +65,15 @@ export function ObjectArrayControl({ | |||
| const options: ArrayControlOptions = | |||
| (uischema.options as ArrayControlOptions) ?? {} | |||
|
|
|||
| // Note: For primative arrays, ArrayControlProps.data is an array | |||
| // For object arrays, ArrayLayoutProps.data is a number | |||
| const dataSource: any[] = | |||
There was a problem hiding this comment.
Could you try unknown instrad of any here? Any is pretty dangerous and can typically be replaced by unknown without too much work
There was a problem hiding this comment.
Using unknown did not do the trick
There was a problem hiding this comment.
After playing around with it a bit more got it to work
src/controls/ArrayControl.tsx
Outdated
| @@ -28,7 +35,7 @@ export function ObjectArrayControl({ | |||
| rootSchema, | |||
| uischemas, | |||
| required, | |||
| }: ArrayLayoutProps) { | |||
| }: ArrayLayoutProps | ArrayControlProps) { | |||
There was a problem hiding this comment.
This is a smell to me--have you tried splitting this into two components that wrap ancomponent with common logic? Ie create the datasource array in the higher-level components and pass to the shared component?
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Screen.Recording.2024-03-19.at.3.11.50.PM.mov