feat: add oneOf renderer #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrewHoo
commented
Mar 19, 2024
src/controls/OneOfControl.tsx
Outdated
|
|
||
| export const OneOfRenderer = withJsonFormsOneOfProps(OneOfControl) | ||
|
|
||
| function CombinatorTitle({ |
There was a problem hiding this comment.
Note to self; put this in a different file
There was a problem hiding this comment.
Should this be used? This is switching between stylings for the label based on if the label was passed in the controlUISchema and the schema.title?
DrewHoo
commented
Mar 19, 2024
TrangPham
reviewed
Mar 19, 2024
src/controls/OneOfControl.tsx
Outdated
|
|
||
| export const OneOfRenderer = withJsonFormsOneOfProps(OneOfControl) | ||
|
|
||
| function CombinatorTitle({ |
There was a problem hiding this comment.
Should this be used? This is switching between stylings for the label based on if the label was passed in the controlUISchema and the schema.title?
TrangPham
reviewed
Mar 19, 2024
DrewHoo
commented
Mar 20, 2024
DrewHoo
commented
Mar 20, 2024
| rootSchema: JsonSchema | ||
| } | ||
|
|
||
| function handleCombinatorTypeChange({ |
There was a problem hiding this comment.
write a test for the default value bug
DrewHoo
commented
Mar 20, 2024
DrewHoo
force-pushed
the
f/one-of-renderer
branch
from
1b36d73 to
c4e56e9
Compare
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.