Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: HorizontalLayout #38

Merged
merged 11 commits into from
Mar 14, 2024
Merged

feat: HorizontalLayout #38

merged 11 commits into from
Mar 14, 2024

Conversation

NathanFarmer
Copy link
Contributor

@NathanFarmer NathanFarmer commented Mar 14, 2024 •
edited
Loading

  • Add HorizontalLayout
  • Add a single story for each of horizontal and vertical layouts
  • Add basic "does it render" tests for each
  • Change naming convention for layouts

@NathanFarmer NathanFarmer self-assigned this Mar 14, 2024
@NathanFarmer NathanFarmer marked this pull request as ready for review March 14, 2024 17:37
DrewHoo
DrewHoo suggested changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@DrewHoo DrewHoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor note on naming, otherwise looks good

@NathanFarmer NathanFarmer requested a review from DrewHoo March 14, 2024 19:14
@NathanFarmer NathanFarmer changed the title feat: HorizontalLayoutRenderer feat: HorizontalLayout Mar 14, 2024
@NathanFarmer NathanFarmer merged commit b41afab into main Mar 14, 2024
2 of 3 checks passed
@NathanFarmer NathanFarmer deleted the f/FE-53/horizontal-layout branch March 14, 2024 19:42
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrewHoo DrewHoo DrewHoo approved these changes

@TrangPham TrangPham Awaiting requested review from TrangPham

Assignees

@NathanFarmer NathanFarmer

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NathanFarmer @DrewHoo