Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add CI test build step and update build libs #36

Merged
merged 12 commits into from
Mar 13, 2024
Merged

fix: Add CI test build step and update build libs #36

merged 12 commits into from
Mar 13, 2024

Conversation

NathanFarmer
Copy link
Contributor

  • Update cjs build target from ES6 to ESNEXT
  • Add CI step to test build

@NathanFarmer NathanFarmer requested a review from DrewHoo March 13, 2024 18:06
@NathanFarmer NathanFarmer self-assigned this Mar 13, 2024
@NathanFarmer NathanFarmer changed the title fix: fix: Add CI test build step and update build targets Mar 13, 2024
DrewHoo
DrewHoo suggested changes Mar 13, 2024
View reviewed changes
tsconfig.cjs.json Outdated Show resolved Hide resolved
.github/workflows/tests.yaml Outdated

- name: Dry-run of build
shell: bash
run: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a cli arg that specifies a dry run here. Also curious why the pipe operator?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DrewHoo I looked for dry run, but the only thing I could find was tsc --build --dry and that doesn't fail like tsc -p does 🤷🏻

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you look at https://semantic-release.gitbook.io/semantic-release/usage/configuration#dryrun

If this is complicated, i think it's fine to defer & tackle later in another PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried npx semantic-release --dry-run, but it doesn't fail that way either.

@NathanFarmer NathanFarmer changed the title fix: Add CI test build step and update build targets fix: Add CI test build step and update build libs Mar 13, 2024
@NathanFarmer NathanFarmer marked this pull request as ready for review March 13, 2024 18:57
@NathanFarmer NathanFarmer requested a review from DrewHoo March 13, 2024 18:58
@NathanFarmer NathanFarmer merged commit a3e6ab6 into main Mar 13, 2024
2 of 3 checks passed
@NathanFarmer NathanFarmer deleted the m/build-compiler-settings branch March 13, 2024 19:11
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrewHoo DrewHoo DrewHoo approved these changes

Assignees

@NathanFarmer NathanFarmer

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NathanFarmer @DrewHoo