Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DateTimeControl): use data if present #105

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

ashmortar
Copy link
Contributor

Currently, If a form is rendered with and pre-populated values in data the DatePicker does not get set with the value from the form.

This fixes that behavior and adds a story and test to prevent regressions.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.65%. Comparing base (7f1994c) to head (cf317e2).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   77.11%   77.65%   +0.54%     
==========================================
  Files          40       40              
  Lines         533      546      +13     
  Branches      102      104       +2     
==========================================
+ Hits          411      424      +13     
  Misses         83       83              
  Partials       39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashmortar ashmortar force-pushed the b/PH-1604/use-data-for-initial-value-if-present branch 3 times, most recently from d238539 to 6188305 Compare October 23, 2024 18:27
@ashmortar ashmortar force-pushed the b/PH-1604/use-data-for-initial-value-if-present branch from 6188305 to cf317e2 Compare October 23, 2024 21:08
Copy link
Contributor

@NathanFarmer NathanFarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇🏻

@ashmortar ashmortar merged commit fadef43 into main Oct 23, 2024
4 of 5 checks passed
@ashmortar ashmortar deleted the b/PH-1604/use-data-for-initial-value-if-present branch October 23, 2024 21:37
Copy link

🎉 This PR is included in version 1.22.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants