FEATURE: Setup Actions on storybook (#22)

great-expectations · Mar 7, 2024 · 37cf52b · 37cf52b
1 parent 946757e
commit 37cf52b
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 7 deletions.
diff --git a/.storybook/main.ts b/.storybook/main.ts
@@ -5,8 +5,7 @@ const config: StorybookConfig = {
   addons: [
     "@storybook/addon-links",
     "@storybook/addon-essentials",
-    "@storybook/addon-onboarding",
-    "@storybook/addon-interactions",
+    "@storybook/addon-onboarding",    
   ],
   framework: {
     name: "@storybook/react-vite",

diff --git a/src/common/StorybookAntDJsonForm.tsx b/src/common/StorybookAntDJsonForm.tsx
@@ -14,6 +14,7 @@ type Props = {
   uiSchema?: UISchema;
   uiSchemaRegistryEntries?: JsonFormsUISchemaRegistryEntry[];
   config?: Record<string, unknown>;
+  onChange: (data: Record<string, unknown>) => void;
 };
 
 // this component exists to facilitate storybook rendering
@@ -24,14 +25,19 @@ export function StorybookAntDJsonForm({
   uiSchemaRegistryEntries,
   rendererRegistryEntries,
   config,
+  onChange
 }: Props) {
   const [data, setData] = useState(initialData);
+  const updateData = (newData: Record<string, unknown>) => {
+    setData(newData);
+    onChange(newData);
+  }
   return (
     <AntDJsonForm
       uiSchema={uiSchema}
       jsonSchema={jsonSchema}
       data={data}
-      updateData={(newData) => setData(newData)}
+      updateData={(newData) => updateData(newData)}
       uiSchemaRegistryEntries={uiSchemaRegistryEntries}
       rendererRegistryEntries={rendererRegistryEntries}
       config={config}

diff --git a/src/stories/controls/AlertControl.stories.tsx b/src/stories/controls/AlertControl.stories.tsx
@@ -29,10 +29,14 @@ const meta: Meta<typeof StorybookAntDJsonForm> = {
     ]
   },
   argTypes: {
-    rendererRegistryEntries: {},
+    rendererRegistryEntries: { table: { disable: true } },
+    uiSchemaRegistryEntries: { table: { disable: true } },
     jsonSchema: {
       control: "object",
-    }
+    },
+    data: {table: {disable: true}}, 
+    config: {control: "object"},
+    onChange: {table: {disable: true, action: "on-change"}},
   }
 };
 

diff --git a/src/stories/controls/BooleanControl.stories.tsx b/src/stories/controls/BooleanControl.stories.tsx
@@ -6,7 +6,6 @@ import { StorybookAntDJsonForm } from "../../common/StorybookAntDJsonForm";
 const schema = {
   type: "object",
   properties: { checkbox: { type: "boolean" } },
-  // required: ["name"],
 };
 
 const meta: Meta<typeof StorybookAntDJsonForm> = {
@@ -37,10 +36,13 @@ const meta: Meta<typeof StorybookAntDJsonForm> = {
   // More on argTypes: https://storybook.js.org/docs/api/argtypes
   argTypes: {
     rendererRegistryEntries: { table: { disable: true } },
+    uiSchemaRegistryEntries: { table: { disable: true } },
     jsonSchema: {
       control: "object",
-      description: "this is a simple schema with one property (name)",
     },
+    data: {table: {disable: true}}, 
+    config: {control: "object"},
+    onChange: {table: {disable: true, action: "on-change"}},
   },
 };
 

diff --git a/src/stories/controls/TextControl.stories.tsx b/src/stories/controls/TextControl.stories.tsx
@@ -41,6 +41,10 @@ const meta: Meta<typeof StorybookAntDJsonForm> = {
       control: "object",
       description: "this is a simple schema with one property (name)",
     },
+    uiSchemaRegistryEntries: { table: { disable: true } },
+    data: {table: {disable: true}}, 
+    config: {control: "object"},
+    onChange: {table: {disable: true, action: "on-change"}},
   },
 };