Switch tctl top to use charmbracelet/bubbletea
#51389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
added
the
no-changelog
rosstimothy
force-pushed
the
tross/tctl_top_improvements
branch
from
46c9790 to
32c7e33
Compare
|
Side by side comparison of the current version of tctl top and this branch against the same cluster: |
rosstimothy
force-pushed
the
tross/tctl_top_improvements
branch
2 times, most recently
from
09e3de2 to
486bc8f
Compare
rosstimothy
force-pushed
the
tross/tctl_top_improvements
branch
from
486bc8f to
09a4bc5
Compare
espadolini
approved these changes
Jan 24, 2025
rosstimothy
force-pushed
the
tross/tctl_top_improvements
branch
from
09a4bc5 to
3cde547
Compare
|
Friendly ping @Joerger |
fspmarshall
approved these changes
Jan 28, 2025
public-teleport-github-review-bot
bot
removed the request for review
from Joerger
rosstimothy
force-pushed
the
tross/tctl_top_improvements
branch
from
3cde547 to
87fdabc
Compare
Most of the functionality was untouched, there were only few deviations to the original styling and alignment of components. The most notable changes are as follows: - The backend and cache tables no longer have a range column, range requests are now indicated by a preceding ®. - The watcher graphs are rendered with a different library and no longer have a confusing x axis - The colors do not match the original version - The cluster stats page includes the role count - Errors retrieving metrics no longer exits the process. The footer is updated to display errors and requires manual intervention to exit. If errors are intermittent future successful reports will restore functionality.
rosstimothy
force-pushed
the
tross/tctl_top_improvements
branch
from
87fdabc to
75e0528
Compare
|
@rosstimothy See the table below for backport results.
|
rosstimothy
added a commit
that referenced
this pull request
Jan 28, 2025
Most of the functionality was untouched, there were only few deviations to the original styling and alignment of components. The most notable changes are as follows: - The backend and cache tables no longer have a range column, range requests are now indicated by a preceding ®. - The watcher graphs are rendered with a different library and no longer have a confusing x axis - The colors do not match the original version - The cluster stats page includes the role count - Errors retrieving metrics no longer exits the process. The footer is updated to display errors and requires manual intervention to exit. If errors are intermittent future successful reports will restore functionality.
rosstimothy
added a commit
that referenced
this pull request
Jan 28, 2025
Most of the functionality was untouched, there were only few deviations to the original styling and alignment of components. The most notable changes are as follows: - The backend and cache tables no longer have a range column, range requests are now indicated by a preceding ®. - The watcher graphs are rendered with a different library and no longer have a confusing x axis - The colors do not match the original version - The cluster stats page includes the role count - Errors retrieving metrics no longer exits the process. The footer is updated to display errors and requires manual intervention to exit. If errors are intermittent future successful reports will restore functionality.
rosstimothy
added a commit
that referenced
this pull request
Jan 28, 2025
Most of the functionality was untouched, there were only few deviations to the original styling and alignment of components. The most notable changes are as follows: - The backend and cache tables no longer have a range column, range requests are now indicated by a preceding ®. - The watcher graphs are rendered with a different library and no longer have a confusing x axis - The colors do not match the original version - The cluster stats page includes the role count - Errors retrieving metrics no longer exits the process. The footer is updated to display errors and requires manual intervention to exit. If errors are intermittent future successful reports will restore functionality.
rosstimothy
added a commit
that referenced
this pull request
Jan 28, 2025
Most of the functionality was untouched, there were only few deviations to the original styling and alignment of components. The most notable changes are as follows: - The backend and cache tables no longer have a range column, range requests are now indicated by a preceding ®. - The watcher graphs are rendered with a different library and no longer have a confusing x axis - The colors do not match the original version - The cluster stats page includes the role count - Errors retrieving metrics no longer exits the process. The footer is updated to display errors and requires manual intervention to exit. If errors are intermittent future successful reports will restore functionality.
rosstimothy
added a commit
that referenced
this pull request
Jan 28, 2025
Most of the functionality was untouched, there were only few deviations to the original styling and alignment of components. The most notable changes are as follows: - The backend and cache tables no longer have a range column, range requests are now indicated by a preceding ®. - The watcher graphs are rendered with a different library and no longer have a confusing x axis - The colors do not match the original version - The cluster stats page includes the role count - Errors retrieving metrics no longer exits the process. The footer is updated to display errors and requires manual intervention to exit. If errors are intermittent future successful reports will restore functionality.
rosstimothy
added a commit
that referenced
this pull request
Jan 28, 2025
Most of the functionality was untouched, there were only few deviations to the original styling and alignment of components. The most notable changes are as follows: - The backend and cache tables no longer have a range column, range requests are now indicated by a preceding ®. - The watcher graphs are rendered with a different library and no longer have a confusing x axis - The colors do not match the original version - The cluster stats page includes the role count - Errors retrieving metrics no longer exits the process. The footer is updated to display errors and requires manual intervention to exit. If errors are intermittent future successful reports will restore functionality.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
Most of the functionality was untouched, there were only few deviations to the original styling and alignment of components. The most notable changes are as follows: - The backend and cache tables no longer have a range column, range requests are now indicated by a preceding ®. - The watcher graphs are rendered with a different library and no longer have a confusing x axis - The colors do not match the original version - The cluster stats page includes the role count - Errors retrieving metrics no longer exits the process. The footer is updated to display errors and requires manual intervention to exit. If errors are intermittent future successful reports will restore functionality.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
Most of the functionality was untouched, there were only few deviations to the original styling and alignment of components. The most notable changes are as follows: - The backend and cache tables no longer have a range column, range requests are now indicated by a preceding ®. - The watcher graphs are rendered with a different library and no longer have a confusing x axis - The colors do not match the original version - The cluster stats page includes the role count - Errors retrieving metrics no longer exits the process. The footer is updated to display errors and requires manual intervention to exit. If errors are intermittent future successful reports will restore functionality.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
Most of the functionality was untouched, there were only few deviations to the original styling and alignment of components. The most notable changes are as follows: - The backend and cache tables no longer have a range column, range requests are now indicated by a preceding ®. - The watcher graphs are rendered with a different library and no longer have a confusing x axis - The colors do not match the original version - The cluster stats page includes the role count - Errors retrieving metrics no longer exits the process. The footer is updated to display errors and requires manual intervention to exit. If errors are intermittent future successful reports will restore functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the functionality was untouched, there were only few deviations to the original styling and alignment of components. The most notable changes are as follows:
®.