RFD 195: Windows VNet Support #50850
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
reviewed
Jan 8, 2025
Comment on lines
+160
to
+168
| When calling the `AuthenticateProcess` RPC, the Windows service will: | ||
| 1. Create a Windows named pipe and give the installing user SID permission to open the pipe. | ||
| 1. Pass the name of the pipe (via the RPC) to the user process. | ||
| 1. Wait for the user process to dial the named pipe. | ||
| 1. Use the Windows API `GetNamedPipeClientProcessId` to get the pipe client | ||
| process handle. | ||
| 1. Once it has the user process handle, it can confirm the path of the exe | ||
| matches the path of the Windows service, and confirm that the exe is signed | ||
| by the same issuer as itself. |
There was a problem hiding this comment.
What happens if this fails for some reason? What is the UX for the user?
Comment on lines
+241
to
+244
| // root_cluster is the root cluster in which the app is found. | ||
| string root_cluster = 2; | ||
| // leaf_cluster is the leaf cluster in which the app is found. | ||
| string leaf_cluster = 3; |
There was a problem hiding this comment.
Will an app appear in both? Could this be flattened to a single cluster field?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.