Remove v13 mentions in the docs #50831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptgott
added
no-changelog
github-actions
bot
requested review from
greedy52,
hugoShaka,
marcoandredinis,
mmcallister,
nklaassen,
r0mant,
tigrato,
xinding33 and
zmb3
|
Amplify deployment status
|
marcoandredinis
approved these changes
Jan 7, 2025
mmcallister
approved these changes
Jan 7, 2025
Our policy is to remove mentions of the version prior to the most recent deprecated version. This change includes mentions of v13 in Helm chart values file comments.
ptgott
force-pushed
the
paul.gottschling/2025-01-07-v13-rm
branch
from
b822a9d to
345567d
Compare
hugoShaka
reviewed
Jan 7, 2025
| `public.ecr.aws/gravitational/teleport`. Those images will be removed with | ||
| teleport 15. | ||
|
|
||
| Hardened distroless images are used by default. |
There was a problem hiding this comment.
This sentence is hard to understand for people without Teleport nor distroless context. Can you add a link to https://goteleport.com/docs/installation/#interacting-with-distroless-images ?
There was a problem hiding this comment.
Changed in 3e57f58. I added a descriptive sentence rather than a link so the reader could stay on the same page.
tigrato
approved these changes
Jan 8, 2025
public-teleport-github-review-bot
bot
removed request for
greedy52,
nklaassen and
xinding33
Responds to hugoShaka feedback.
hugoShaka
approved these changes
Jan 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our policy is to remove mentions of the version prior to the most recent deprecated version.
This change includes mentions of v13 in Helm chart values file comments.