-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure no labels will try to be created if none are passed from the yaml #15
Open
markelarizaga
wants to merge
43
commits into
grassedge:master
Choose a base branch
from
SplashThat:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e logging of the action This PR also incorporates the code of 2 depenndecies of the action to the same project. SWP-557755 Update dependency to get is from the splash project SWP-557755 Update dependency to get is from the splash project SWP-557755 Add more info of the returned PR object to be logged into the console SWP-557755 Try to throw more logs about the returned PR object 1.0.2 SWP-557755 PUtting all the code in a single project to ease modification SWP-557755 Fix require path of detect module SWP-557755 Add import of core to use it later in the module
SWP-557755 Delay calls to GH search api to avoid hitting limits
SWP-87550 upgrade version of node to the last allowed version
SWP-95498 Add retrying logic via Octokit Throttling plugin
Make octokit be always throthed
…pr-identification SWP-103984 Make the existing PR identification more strict.
SWP-103984 Update to the newest version of actions/checkout, to avoid warnings
SWP-103984 Correct the path to the entrypoint in the action config file
…endencies. Otherwise, we would have to install the dependencies in a CI or something to generate the build. This commit puts everything back as it was before.
SWP-103984 Recover the build step for the action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if no labels are passed from the workflow's yaml file, this action will attempt to create a label by mistake.
This line:
Will make
labels
be[""]
, and once this is passed togitPrRelease
, a label creation will be attempted given that the length of the array is not 0. This error causes the action to log an error like this when no labels present in the yaml file.Example action config int he yaml:
Error thrown: