Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LLVM-17 optimization level #984

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

khiner
Copy link
Contributor

@khiner khiner commented Dec 15, 2023

I found this while debugging a memory access error crash during stack unwinding when handling parse failure exception (which I'm still investigating, still not sure if that's on my end or Faust's).

Running with -fsanitize=address gave:

==53040==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x00016b443df8 at pc 0x00010e10ca50 bp 0x00016b442c70 sp 0x00016b442420
READ of size 8 at 0x00016b443df8 thread T0
    #0 0x10e10ca4c in __asan_memcpy+0x37c (libclang_rt.asan_osx_dynamic.dylib:arm64+0x50a4c)
    #1 0x10fd9e33c in llvm_dynamic_dsp_factory_aux::initJIT(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>&) llvm_dynamic_dsp_aux.cpp:348
    #2 0x10fda5944 in createDSPFactoryFromSignals(std::__1::basic_string<char, 
    ...

This looks like a simple min/max typo bug to me. (In my case, fOptLevel was 5.)

@sletz sletz merged commit 7f88d7c into grame-cncm:master-dev Dec 15, 2023
3 checks passed
@sletz
Copy link
Member

sletz commented Dec 15, 2023

Right thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants