address observations, merge files, add tests

Signed-off-by: Ruben Vargas <[email protected]>

cmd/root/options.go

@@ -1,20 +1,41 @@
 package root
 
 import (
+	"errors"
 	"fmt"
 	"net/http"
 	"net/http/pprof"
+	"os"
+	"path/filepath"
 	"reflect"
 
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
+	"k8s.io/apimachinery/pkg/runtime/serializer"
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/manager"
 	"sigs.k8s.io/controller-runtime/pkg/webhook"
 
 	configv1alpha1 "github.com/grafana/tempo-operator/api/config/v1alpha1"
 )
 
+var errConfigFileLoading = errors.New("could not read file at path")
+
+func loadConfigFile(scheme *runtime.Scheme, outConfig *configv1alpha1.ProjectConfig, configFile string) error {
+	content, err := os.ReadFile(filepath.Clean(configFile))
+	if err != nil {
+		return fmt.Errorf("%w %s", errConfigFileLoading, configFile)
+	}
+
+	codecs := serializer.NewCodecFactory(scheme)
+
+	if err = runtime.DecodeInto(codecs.UniversalDecoder(), content, outConfig); err != nil {
+		return fmt.Errorf("could not decode file into runtime.Object: %w", err)
+	}
+
+	return nil
+}
+
 // LoadConfig initializes the controller configuration, optionally overriding the defaults
 // from a provided configuration file.
 func LoadConfig(scheme *runtime.Scheme, configFile string) (*configv1alpha1.ProjectConfig, ctrl.Options, error) {

cmd/root/root.go

@@ -2,7 +2,6 @@ package root
 
 import (
 	"context"
-
 	grafanav1 "github.com/grafana/grafana-operator/v5/api/v1beta1"
 	configv1 "github.com/openshift/api/config/v1"
 	openshiftoperatorv1 "github.com/openshift/api/operator/v1"
@@ -44,8 +43,6 @@ func init() {
 	//+kubebuilder:scaffold:scheme
 }
 
-//var errConfigFileLoading = errors.New("could not read file at path")
-
 func readConfig(cmd *cobra.Command, configFile string) error {
 	// default controller configuration
 	ctrlCfg, options, err := LoadConfig(scheme, configFile)