Include Servicemontiors
and Podlogs
CRDs in grafana-agent helm chart
#6220
+1,390
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The new grafana-agent flow helm chart can automatically install CRDs. But it includes only
Podlogs
. With this PR it will includeServicemonitors
andPodmonitors
CRDs too. Servicemonitors are widely used by a lot of helm charts, and the "flow version" of grafana-agent also supports it via prometheus.operator.servicemonitorsWhich issue(s) this PR fixes
To use
Servicemonitors
in other helm charts, first I have to install that CRD. The grafana-agent helm chart already maintain a CRD, so it would be easier to includeServicemonitors
CRD in it, so we don't have to install that CRD separately.Notes to the Reviewer
PR Checklist