[23.1] Fix preview build #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--enable-preview part of native-image flags needs some additional jars, svm-foreign.jar, for example, for it to work. Add it to the dependency build and copy the relevant artefact to it's place.
oracle-contributor-agreement
bot
added
the
OCA Verified
|
I'll forward-port this to 24.0 and master once CI passes. |
|
Thanks for the review! |
jerboaa
force-pushed
the
fix_preview_build
branch
from
72f4e85 to
0915fe2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently using
--enable-previewis broken for Mandrel builds, since it doesn't installsvm-foreign.jarin the right directory. This patch adds the relevant dependency (SVM_FOREIGN) and then installs it.Closes: graalvm/mandrel#658