Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.0] Introduce --disable-debuginfo-stripping option #387

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Jan 11, 2024

Enables the use of --disable-debuginfo-stripping which was introduced
in oracle/graal#7624

Enables the use of `--disable-debuginfo-stripping` which was introduced
in oracle/graal#7624
@zakkak zakkak requested a review from jerboaa January 11, 2024 13:18
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 11, 2024
@zakkak
Copy link
Collaborator Author

zakkak commented Jan 11, 2024

Follow up PRs will be created for 23.1, 24.0, and master once this gets approved.

@jerboaa
Copy link
Collaborator

jerboaa commented Jan 11, 2024

Enables the use of --disable-debuginfo-stripping which was introduced in oracle/graal#7624

Right, that was introduced to master with that change, but it also got backported to 23.0 here:
oracle/graal@cdb0389

Therefore, adding that option to mandrel-packaging seems fine with that in place.

Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch itself is fine, but could you update the workflow file to check out the right mx version, like our mandrel CI does?

PR checker fails due to:

2024-01-11T13:21:02.9038428Z Exception in thread "main" java.lang.RuntimeException: java.nio.file.NoSuchFileException: /home/runner/work/mandrel-packaging/mandrel-packaging/mandrel/substratevm/mxbuild/linux-amd64/com.oracle.svm.native.libchelper/amd64/liblibchelper.a
2024-01-11T13:21:02.9038637Z 	at FileSystem.copy(build.java:1529)
2024-01-11T13:21:02.9038742Z 	at build.main(build.java:182)
2024-01-11T13:21:02.9039805Z Caused by: java.nio.file.NoSuchFileException: /home/runner/work/mandrel-packaging/mandrel-packaging/mandrel/substratevm/mxbuild/linux-amd64/com.oracle.svm.native.libchelper/amd64/liblibchelper.a

Suggesting it's using mx suitable for master, only.

@zakkak
Copy link
Collaborator Author

zakkak commented Jan 11, 2024

Thanks for mentioning this, I was struggling to see what's wrong... :)

@zakkak zakkak force-pushed the 2024-01-11-23.0-add-disable-debuginfo-stripping-option branch from 8041cfb to 00a7c8a Compare January 11, 2024 14:52
jerboaa

This comment was marked as outdated.

@jerboaa
Copy link
Collaborator

jerboaa commented Jan 11, 2024

@zakkak Oh, I've just realized this doesn't yet work on Windows:

 VERSION=$(jq -r .mx_version ${MANDREL_REPO}/common.json): D:\a\_temp\9b0ef8ba-4f46-4891-af53-35e0c27ce28b.ps1:2
Line |
   2 |  VERSION=$(jq -r .mx_version ${MANDREL_REPO}/common.json)
     |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | The term 'VERSION=$(jq -r .mx_version ${MANDREL_REPO}/common.json)' is not recognized as a name of a cmdlet,
     | function, script file, or executable program. Check the spelling of the name, or if a path was included, verify
     | that the path is correct and try again.

@zakkak zakkak force-pushed the 2024-01-11-23.0-add-disable-debuginfo-stripping-option branch from 00a7c8a to d4b0980 Compare January 11, 2024 18:43
@zakkak zakkak requested a review from jerboaa January 11, 2024 18:54
Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. GHA clean now.

@zakkak zakkak merged commit 408a0c4 into graalvm:23.0 Jan 11, 2024
4 checks passed
@zakkak zakkak deleted the 2024-01-11-23.0-add-disable-debuginfo-stripping-option branch January 11, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants