-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[23.0] Introduce --disable-debuginfo-stripping
option
#387
[23.0] Introduce --disable-debuginfo-stripping
option
#387
Conversation
Enables the use of `--disable-debuginfo-stripping` which was introduced in oracle/graal#7624
Follow up PRs will be created for |
Right, that was introduced to master with that change, but it also got backported to 23.0 here: Therefore, adding that option to mandrel-packaging seems fine with that in place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch itself is fine, but could you update the workflow file to check out the right mx
version, like our mandrel CI does?
PR checker fails due to:
2024-01-11T13:21:02.9038428Z Exception in thread "main" java.lang.RuntimeException: java.nio.file.NoSuchFileException: /home/runner/work/mandrel-packaging/mandrel-packaging/mandrel/substratevm/mxbuild/linux-amd64/com.oracle.svm.native.libchelper/amd64/liblibchelper.a
2024-01-11T13:21:02.9038637Z at FileSystem.copy(build.java:1529)
2024-01-11T13:21:02.9038742Z at build.main(build.java:182)
2024-01-11T13:21:02.9039805Z Caused by: java.nio.file.NoSuchFileException: /home/runner/work/mandrel-packaging/mandrel-packaging/mandrel/substratevm/mxbuild/linux-amd64/com.oracle.svm.native.libchelper/amd64/liblibchelper.a
Suggesting it's using mx suitable for master, only.
Thanks for mentioning this, I was struggling to see what's wrong... :) |
8041cfb
to
00a7c8a
Compare
@zakkak Oh, I've just realized this doesn't yet work on Windows:
|
00a7c8a
to
d4b0980
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. GHA clean now.
Enables the use of
--disable-debuginfo-stripping
which was introducedin oracle/graal#7624