Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

private gpu view #85

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

AndreSlavescu
Copy link
Collaborator

@AndreSlavescu AndreSlavescu commented Dec 28, 2024

Description

Please provide a brief summary of the changes in this pull request.

Checklist

Before submitting this PR, ensure the following steps have been completed:

  • Run the slash command /verifyruns on your own server.
    • Run the cluster bot on your server:
      python discord-bot.py
    • Start training runs with the slash command /verifyruns.
    • Verify that the bot eventually responds with:
      ✅ All runs completed successfully!
      
      (It may take a few minutes for all runs to finish. In particular, the GitHub
      runs may take a little longer. The Modal run is typically quick.)
      For more information on running a cluster bot on your own server, see
      README.md.

Copy link
Collaborator

@alexzhang13 alexzhang13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the actual behavior of this, @S1ro1 probably will understand better. But my understanding is that either:

  1. The interaction happens relative to the person interacting. So in this case these if statements don't do anything.
  2. The interactions happen per user, in which case this seems fine? But then I am afraid these if conditions trigger for every user, which is also bad.

If we can confirm this works as intended without performance issues I'm happy to use this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants