Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: application timeout in fast-track if only 1 gpu #151

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

S1ro1
Copy link
Collaborator

@S1ro1 S1ro1 commented Jan 23, 2025

Description

Small fix, PR #144 introduced a subtle bug that if only 1 gpu was available, it would not call gpu_view, resulting in the interaction defer not being called. As only 1 command calls this view, I moved the defer into the command as it's not view specific.

Checklist

Before submitting this PR, ensure the following steps have been completed:

  • Run the slash command /verifyruns on your own server.
    • Run the cluster bot on your server:
      python discord-bot.py
    • Start training runs with the slash command /verifyruns.
    • Verify that the bot eventually responds with:
      ✅ All runs completed successfully!
      
      (It may take a few minutes for all runs to finish. In particular, the GitHub
      runs may take a little longer. The Modal run is typically quick.)
      For more information on running a cluster bot on your own server, see
      README.md.

@S1ro1 S1ro1 requested a review from ngc92 January 23, 2025 17:16
@S1ro1 S1ro1 merged commit 1854e3f into main Jan 23, 2025
3 checks passed
@S1ro1 S1ro1 deleted the fix/app-timeout-gpu-view branch January 23, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants