Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MI300X Runners to AMD workflow. #149

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add MI300X Runners to AMD workflow. #149

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d750d27
mi300 changes
saienduri Jan 22, 2025
afa5aba
use preset env git variable
saienduri Jan 22, 2025
c625f7d
add venv activate to script step
saienduri Jan 22, 2025
af733a7
temp pip install amd torch
saienduri Jan 22, 2025
53369a5
remove temp pip install
saienduri Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions .github/workflows/amd_workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,18 @@ on:

jobs:
run:
runs-on: [amdgpu-mi250-x86-64]
runs-on: ${{ matrix.runs-on }}
strategy:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the way we want to handle multiple runners; afaics, this well always run the given code sample on both types of AMD cards. Instead, the card should be selectable by an input argument that is given to the job.

Both runners should be registered in src/discord-cluster-manager/consts.py, and
https://github.com/gpu-mode/discord-cluster-manager/blob/main/src/discord-cluster-manager/cogs/github_cog.py#L35-L40
needs to be updated

fail-fast: false
matrix:
include:
- name: mi300
runs-on: amdgpu-mi300-x86-64
venv-dir: $GITHUB_WORKSPACE
- name: mi250
runs-on: amdgpu-mi250-x86-64
venv-dir: /groups/aig_sharks/pytorch_venv
timeout-minutes: 10
env:
VENV_DIR: /groups/aig_sharks/pytorch_venv
steps:
- uses: actions/checkout@v3
- name: Setup Python
Expand All @@ -35,10 +43,9 @@ jobs:
- name: Setup Virtual Environment and Install Dependencies
shell: bash
run: |
python -m venv ${VENV_DIR}
source ${VENV_DIR}/bin/activate
python -m venv ${{ matrix.venv-dir }}
source ${{ matrix.venv-dir }}/bin/activate
pip install --upgrade pip

if [[ -n "${{ github.event.inputs.requirements }}" ]]; then
cat > "requirements.txt" <<'EOL'
${{ github.event.inputs.requirements }}
Expand All @@ -48,13 +55,14 @@ jobs:
- name: Run script
shell: bash
run: |
source ${{ matrix.venv-dir }}/bin/activate
python3 .github/workflows/runner.py
cat result.json # Debug: show output

- name: Upload training artifacts
uses: actions/upload-artifact@v4
if: always()
with:
name: run-result
name: run-result-${{ matrix.name }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this name needs to be unchanged so the bot knows how to read the results.

path: |
result.json
Loading