Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pytorch script runner to use pipe #131

Merged
merged 3 commits into from
Jan 14, 2025
Merged

update pytorch script runner to use pipe #131

merged 3 commits into from
Jan 14, 2025

Conversation

ngc92
Copy link
Collaborator

@ngc92 ngc92 commented Jan 13, 2025

Updates the python interface to match the recent cuda changes.
Turns out run_cuda_program actually doesn't do anything cuda specific, so we can instead reuse this piece of code.

In the current state, standalone python (and also cuda, I think) scripts are somewhat broken, as they never use the special pipe to communicate their success status, so these runs will now always be considered failed.

@ngc92 ngc92 force-pushed the ngc92/pytorch-runner branch 5 times, most recently from dc26e38 to 1271b72 Compare January 13, 2025 22:12
@ngc92 ngc92 force-pushed the ngc92/pytorch-runner branch from 1271b72 to 6d030d0 Compare January 14, 2025 13:49
@alexzhang13 alexzhang13 self-requested a review January 14, 2025 16:51
Copy link
Collaborator

@alexzhang13 alexzhang13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working and tested locally. Thanks!

@ngc92 ngc92 force-pushed the ngc92/pytorch-runner branch from 021d0a0 to 348e36c Compare January 14, 2025 17:04
@ngc92 ngc92 merged commit d26faaf into main Jan 14, 2025
3 checks passed
@ngc92 ngc92 deleted the ngc92/pytorch-runner branch January 14, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants