Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency caching #10

Closed
wants to merge 15 commits into from
Closed

dependency caching #10

wants to merge 15 commits into from

Conversation

AndreSlavescu
Copy link
Collaborator

@AndreSlavescu AndreSlavescu commented Nov 7, 2024

re:

#9

Results after run locally (macbook pro m1)

==================================================
                BENCHMARK RESULTS                 
==================================================
Test Type                     Duration            
--------------------------------------------------
With Cache                    26.76s              
Without Cache                 68.07s              
With UV                       9.28s               
Cache Speedup                 41.31s              
UV vs Cache Speedup           17.48s              
==================================================

Test Output:
--------------------------------------------------
Matrix multiplication result:
 [[19 22]
 [43 50]]```

# pip install torch - need to find a way to cache this otherwise it will take a long time to install

python -m pip install --upgrade pip
pip install -r requirements.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need most these requirements to run the file, we mostly need them to run the bot which is not yet properly tested in CI

test_workflow.py Outdated
@@ -0,0 +1,58 @@
import subprocess
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the github action should report how long it takes to run which will be more indicative of actual performance. see my caching prs i noticed caching would be slower than without

@msaroufim msaroufim closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants