-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependency caching #10
Conversation
.github/workflows/train_workflow.yml
Outdated
# pip install torch - need to find a way to cache this otherwise it will take a long time to install | ||
|
||
python -m pip install --upgrade pip | ||
pip install -r requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need most these requirements to run the file, we mostly need them to run the bot which is not yet properly tested in CI
test_workflow.py
Outdated
@@ -0,0 +1,58 @@ | |||
import subprocess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the github action should report how long it takes to run which will be more indicative of actual performance. see my caching prs i noticed caching would be slower than without
re:
#9
Results after run locally (macbook pro m1)