fix(plugins/maxcompute): handle schema-based table listing in resource retrieval #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e retrieval - Refactored the `GetResources` method to account for schema-based table listings in MaxCompute. - Integrated `odpsClient` to retrieve schemas and iterate over them when fetching tables. - Fixed handling of schema exclusions based on credentials. - Ensured pagination support for table listing using markers. - Updated resource URN generation to include schema information when available.
rahmatrhd
requested changes
Jan 10, 2025
| return nil, err | ||
| } | ||
|
|
||
| schemaRes := map[string]struct{}{"default": {}} |
There was a problem hiding this comment.
do we need to hardcode "default" here? is the list schemas API not returning the default schema record?
There was a problem hiding this comment.
It will returning default schema when SchemaName is nil (this is the previous implementation)
So with this changes, we need to add default there to ensure default schema is iterated
There was a problem hiding this comment.
yes understand that, but when we are fetching the list of schemas, are we not getting default schema in the list?
There was a problem hiding this comment.
Got it, this is to ensure that default scheme is included on list scheme (since I can't run it from my local because I dont have any access key for max compute)
…e retrieval patch 2
…e retrieval patch 3
rahmatrhd
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetResourcesmethod to account for schema-based table listings in MaxCompute.odpsClientto retrieve schemas and iterate over them when fetching tables.