feat(oss): enable bucket access for ram role #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahmatrhd
reviewed
Dec 24, 2024
plugins/providers/oss/provider.go
Outdated
| } | ||
|
|
||
| return subParts[1], nil | ||
| return "", fmt.Errorf("invalid account type") |
There was a problem hiding this comment.
Suggested change
| return "", fmt.Errorf("invalid account type") | |
| return "", fmt.Errorf("invalid account type: %q", accountType) |
rahmatrhd
reviewed
Dec 24, 2024
plugins/providers/oss/provider.go
Outdated
| mainAccountID := accountIDParts[3] | ||
| roleNameParts := strings.Split(accountIDParts[4], "/") | ||
| if len(roleNameParts) < 2 { | ||
| return "", fmt.Errorf("invalid accountID format") |
There was a problem hiding this comment.
Suggested change
| return "", fmt.Errorf("invalid accountID format") | |
| return "", fmt.Errorf("invalid accountID format: %q", accountID) |
rahmatrhd
reviewed
Dec 24, 2024
plugins/providers/oss/provider.go
Outdated
| return "", fmt.Errorf("invalid accountID format") | ||
| accountIDParts := strings.Split(accountID, ":") | ||
| if len(accountIDParts) < 5 { | ||
| return "", fmt.Errorf("invalid accountID format") |
There was a problem hiding this comment.
Suggested change
| return "", fmt.Errorf("invalid accountID format") | |
| return "", fmt.Errorf("invalid accountID format: %q", accountID) |
rahmatrhd
reviewed
Dec 24, 2024
plugins/providers/oss/provider.go
Outdated
|
|
||
| subParts := strings.Split(accountIDParts[1], ":") | ||
| if len(subParts) < 2 { | ||
| return "", fmt.Errorf("invalid accountID format") |
There was a problem hiding this comment.
Suggested change
| return "", fmt.Errorf("invalid accountID format") | |
| return "", fmt.Errorf("invalid accountID format: %q", accountID) |
rahmatrhd
reviewed
Dec 24, 2024
plugins/providers/oss/provider.go
Outdated
| if accountType == AccountTypeRAMUser { | ||
| accountIDParts := strings.Split(accountID, "$") | ||
| if len(accountIDParts) < 2 { | ||
| return "", fmt.Errorf("invalid accountID format") |
There was a problem hiding this comment.
Suggested change
| return "", fmt.Errorf("invalid accountID format") | |
| return "", fmt.Errorf("invalid accountID format: %q", accountID) |
ayushi0014
force-pushed
the
oss-ram-role
branch
from
ae5b295 to
dee7cd4
Compare
ayushi0014
force-pushed
the
oss-ram-role
branch
from
dee7cd4 to
d8d1548
Compare
rahmatrhd
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.