Room range updates #1133
Merged
Room range updates #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtasonye
reviewed
Feb 2, 2025
There was a problem hiding this comment.
I think the function would be better named "GetMissingRoomRanges()"
There was a problem hiding this comment.
GetMissingRoomRanges would imply the return of a room range object which is not the case for this function. instead we are returning a list of room objects. GetMissedRooms may make more sense for this. I will make the update soon
jtasonye
reviewed
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API to get list of rooms that are not included in any of the room ranges